Conversation
parcing - ok transition to the second vc - ok chart - ok realm - fail
Refactoring
Building success. Bug fix is in process.
… screen is reloaded twice, manually. Bug fix is in process.
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
|
|
||
| struct GithubStarDates { | ||
| let starDatesID: String | ||
| let dates: String |
Collaborator
There was a problem hiding this comment.
dates: String смущает. Даты во множественном числе в виде строки... Что сохраняется в этой переменной?
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
svallex
reviewed
Nov 12, 2020
| reloadDispatchGroup.leave() | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Хороший потенциал для рефакторинга: метод получился довольно большой, выполняет несколько задач, большая вложенность блоков...
Просматривается разделение на отдельные методы (или даже сущности): подготовка запроса, парсинг моделей и т.д.
svallex
reviewed
Nov 13, 2020
| func getCurrentRepositoryInfo(currentRepositoryInfo: CurrentRepositoryInfo) | ||
| func reloadRepoStars(_ starDates: [RepoStarsByDates]) | ||
| func whenAllDataIsReady() | ||
| func activityIndicatorStop() |
Collaborator
There was a problem hiding this comment.
Данные для второго экрана лучше получать из второго презентера, а не передавать из первого
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review, please!