Doorbots hang on no internet

[skos-ninja]

Last night whilst Baltic were doing maintenance on the internet we discovered that all the doorbots stopped responding to tags.

I believe this might have something to do with the work @johnmckerrell did on logging to Slack however I'm not sure.

When checking the logs for this we were trying the doorbots at around 23:00 BST on 30/08/2018.

[amcewen]

The Internet was down again this morning (after the power outage, I presume). Now fixed, but it caused this problem to recur.

Doing a bit of debugging, the problem is the Slack integration - when there's no Internet, the call to Slack (a) takes ages to time out, and (b) throws an exception when it does. The exception is caught, but in the process all the code to open the door is skipped, so the door is never opened.

The Slack integration needs moving to after the door has been opened, like all the other calls to the Internet (or things that might fail), so that the doors still operate with no network access.

For now I've disabled the Slack integration in the config file.

[Thingomy]

If I may enquire, what does a doorbot use slack for in the first place? On 15 Sep 2018 12:02 pm, "Adrian McEwen" <notifications@github.com> wrote: The Internet was down again this morning (after the power outage, I presume). Now fixed, but it caused this problem to recur. Doing a bit of debugging, the problem is the Slack integration - when there's no Internet, the call to Slack (a) takes ages to time out, and (b) throws an exception when it does. The exception is caught, but in the process all the code to open the door is skipped, so the door is never opened. The Slack integration needs moving to after the door has been opened, like all the other calls to the Internet (or things that might fail), so that the doors still operate with no network access. For now I've disabled the Slack integration in the config file. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIulC0WJRxNOcHjtBnNSS34qOtNC5ePkks5ubN44gaJpZM4WU-JZ> .

[johnmckerrell]

It reports entries to a private slack channel, so that we can be more aware who’s in out of hours.

…

-- Sent from my mobile phone hence brevity and errors

On 15 Sep 2018, at 12:09, Thingomy ***@***.***> wrote: If I may enquire, what does a doorbot use slack for in the first place? On 15 Sep 2018 12:02 pm, "Adrian McEwen" ***@***.***> wrote: The Internet was down again this morning (after the power outage, I presume). Now fixed, but it caused this problem to recur. Doing a bit of debugging, the problem is the Slack integration - when there's no Internet, the call to Slack (a) takes ages to time out, and (b) throws an exception when it does. The exception is caught, but in the process all the code to open the door is skipped, so the door is never opened. The Slack integration needs moving to after the door has been opened, like all the other calls to the Internet (or things that might fail), so that the doors still operate with no network access. For now I've disabled the Slack integration in the config file. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIulC0WJRxNOcHjtBnNSS34qOtNC5ePkks5ubN44gaJpZM4WU-JZ> . — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.