fix: remove default shutdown event #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original default shutdown event is tightly coupled to HTTP and gRPC servers. If one of any servers is missing, goroutines will be leaked. This PR removes the default shutdown events. These events can be added by using the WithShutdownEvents option. BREAKING CHANGE
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 73 73
=========================================
Hits 73 73
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original default shutdown event is tightly coupled to HTTP and gRPC servers. If one of any servers is missing, goroutines will be leaked. This PR removes the
default shutdown events. These events can be added by using the WithShutdownEvents option.
BREAKING CHANGE