Skip to content

feat: enrich activity detail with what was signed + njump link #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DocNR merged 4 commits into from
Apr 30, 2026
Merged

feat: enrich activity detail with what was signed + njump link #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6442a2e
feat: enrich activity detail with what was signed + njump link
DocNR Apr 30, 2026
70ed25d
build: bump pbxproj to 30 for activity-detail TestFlight
DocNR Apr 30, 2026
4052c0a
fix: pending-approval missing log entry + njump for wrapper kinds (bu…
DocNR Apr 30, 2026
40852a1
ux: ActivityDetailView layout audit + unify per-connection rows
DocNR Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions Clave.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
/* Begin PBXBuildFile section */
006B17A84C114EDF9B129CAE /* NostrConnectParser.swift in Sources */ = {isa = PBXBuildFile; fileRef = 34B139A8E147475F9B40B3D5 /* NostrConnectParser.swift */; };
6D2C503B9EF64C8EA5101CDB /* NostrConnectParser.swift in Sources */ = {isa = PBXBuildFile; fileRef = 34B139A8E147475F9B40B3D5 /* NostrConnectParser.swift */; };
AE01F2A3B4C5D6E700000002 /* ActivitySummary.swift in Sources */ = {isa = PBXBuildFile; fileRef = AE01F2A3B4C5D6E700000001 /* ActivitySummary.swift */; };
AE01F2A3B4C5D6E700000003 /* ActivitySummary.swift in Sources */ = {isa = PBXBuildFile; fileRef = AE01F2A3B4C5D6E700000001 /* ActivitySummary.swift */; };
AE01F2A3B4C5D6E700000005 /* Nip19.swift in Sources */ = {isa = PBXBuildFile; fileRef = AE01F2A3B4C5D6E700000004 /* Nip19.swift */; };
AE01F2A3B4C5D6E700000006 /* Nip19.swift in Sources */ = {isa = PBXBuildFile; fileRef = AE01F2A3B4C5D6E700000004 /* Nip19.swift */; };
B0EBA01E2F90AB01000A0001 /* PendingApprovalBanner.swift in Sources */ = {isa = PBXBuildFile; fileRef = B0EBA01E2F90AB01000A0002 /* PendingApprovalBanner.swift */; };
BD247C1AD3A7497E8DF29530 /* ClientPermissions.swift in Sources */ = {isa = PBXBuildFile; fileRef = 894FE9FF88CD485ABCD31C05 /* ClientPermissions.swift */; };
DD90DE0C2D8944D08B23C606 /* ClientPermissions.swift in Sources */ = {isa = PBXBuildFile; fileRef = 894FE9FF88CD485ABCD31C05 /* ClientPermissions.swift */; };
Expand Down Expand Up @@ -83,6 +87,8 @@
/* Begin PBXFileReference section */
34B139A8E147475F9B40B3D5 /* NostrConnectParser.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NostrConnectParser.swift; sourceTree = "<group>"; };
894FE9FF88CD485ABCD31C05 /* ClientPermissions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ClientPermissions.swift; sourceTree = "<group>"; };
AE01F2A3B4C5D6E700000001 /* ActivitySummary.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ActivitySummary.swift; sourceTree = "<group>"; };
AE01F2A3B4C5D6E700000004 /* Nip19.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Nip19.swift; sourceTree = "<group>"; };
B0EBA01E2F90AB01000A0002 /* PendingApprovalBanner.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PendingApprovalBanner.swift; sourceTree = "<group>"; };
DE7E10B1DE7E10B1DE7E10B1 /* DeveloperSettings.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DeveloperSettings.swift; sourceTree = "<group>"; };
DE7E10C1DE7E10C1DE7E10C1 /* LogExporter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LogExporter.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -210,6 +216,7 @@
EF3D7A572F8BD011005A6545 /* Shared */ = {
isa = PBXGroup;
children = (
AE01F2A3B4C5D6E700000001 /* ActivitySummary.swift */,
EF3D7A582F8BD020005A6545 /* Bech32.swift */,
894FE9FF88CD485ABCD31C05 /* ClientPermissions.swift */,
DE7E10B1DE7E10B1DE7E10B1 /* DeveloperSettings.swift */,
Expand All @@ -221,6 +228,7 @@
EF3D7A5A2F8BD020005A6545 /* LightEvent.swift */,
EF3D7A5B2F8BD020005A6545 /* LightRelay.swift */,
EF3D7A5C2F8BD020005A6545 /* LightSigner.swift */,
AE01F2A3B4C5D6E700000004 /* Nip19.swift */,
EF3D7A5D2F8BD020005A6545 /* SharedConstants.swift */,
EF3D7A5E2F8BD020005A6545 /* SharedKeychain.swift */,
EFCA55B463A619311A35AF3C /* SharedModels.swift */,
Expand Down Expand Up @@ -432,6 +440,8 @@
F60FCE012F8BCAE3000FAC0A /* ForegroundRelaySubscription.swift in Sources */,
B0EBA01E2F90AB01000A0001 /* PendingApprovalBanner.swift in Sources */,
DE7E10C2DE7E10C2DE7E10C2 /* LogExporter.swift in Sources */,
AE01F2A3B4C5D6E700000002 /* ActivitySummary.swift in Sources */,
AE01F2A3B4C5D6E700000005 /* Nip19.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -466,6 +476,8 @@
006B17A84C114EDF9B129CAE /* NostrConnectParser.swift in Sources */,
DE7E10B3DE7E10B3DE7E10B3 /* DeveloperSettings.swift in Sources */,
DE7E10C3DE7E10C3DE7E10C3 /* LogExporter.swift in Sources */,
AE01F2A3B4C5D6E700000003 /* ActivitySummary.swift in Sources */,
AE01F2A3B4C5D6E700000006 /* Nip19.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -619,7 +631,7 @@
CODE_SIGN_ENTITLEMENTS = Clave/Clave.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 29;
CURRENT_PROJECT_VERSION = 31;
DEVELOPMENT_TEAM = 944AF56S27;
ENABLE_PREVIEWS = YES;
GENERATE_INFOPLIST_FILE = YES;
Expand Down Expand Up @@ -657,7 +669,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 29;
CURRENT_PROJECT_VERSION = 31;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 944AF56S27;
ENABLE_PREVIEWS = YES;
Expand Down Expand Up @@ -693,7 +705,7 @@
buildSettings = {
BUNDLE_LOADER = "$(TEST_HOST)";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 29;
CURRENT_PROJECT_VERSION = 31;
DEVELOPMENT_TEAM = 944AF56S27;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 26.4;
Expand All @@ -715,7 +727,7 @@
buildSettings = {
BUNDLE_LOADER = "$(TEST_HOST)";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 29;
CURRENT_PROJECT_VERSION = 31;
DEVELOPMENT_TEAM = 944AF56S27;
GENERATE_INFOPLIST_FILE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 26.4;
Expand All @@ -736,7 +748,7 @@
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 29;
CURRENT_PROJECT_VERSION = 31;
DEVELOPMENT_TEAM = 944AF56S27;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 0.1.0;
Expand All @@ -756,7 +768,7 @@
isa = XCBuildConfiguration;
buildSettings = {
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 29;
CURRENT_PROJECT_VERSION = 31;
DEVELOPMENT_TEAM = 944AF56S27;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 0.1.0;
Expand All @@ -777,7 +789,7 @@
buildSettings = {
CODE_SIGN_ENTITLEMENTS = ClaveNSE/ClaveNSE.entitlements;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 29;
CURRENT_PROJECT_VERSION = 31;
DEVELOPMENT_TEAM = 944AF56S27;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = ClaveNSE/Info.plist;
Expand Down Expand Up @@ -808,7 +820,7 @@
CODE_SIGN_ENTITLEMENTS = ClaveNSE/ClaveNSE.entitlements;
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 29;
CURRENT_PROJECT_VERSION = 31;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = 944AF56S27;
GENERATE_INFOPLIST_FILE = YES;
Expand Down
1 change: 1 addition & 0 deletions Clave/AppState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ final class AppState {
privateKey: privateKey,
requestEvent: requestEvent,
skipProtection: true,
skipDedupe: true,
responseRelayUrl: request.responseRelayUrl
)
SharedStorage.removePendingRequest(id: request.id)
Expand Down
Loading