Add preferred release groups for auto-download and filtering#491
Merged
Doezer merged 9 commits intorelease/1.3.0from Apr 1, 2026
Merged
Add preferred release groups for auto-download and filtering#491Doezer merged 9 commits intorelease/1.3.0from
Doezer merged 9 commits intorelease/1.3.0from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a 'Preferred Release Groups' feature, enabling users to prioritize specific release groups for auto-downloads and filter search results. The changes include a new settings UI component, database schema updates, and logic in the auto-search cron job to apply these preferences. Review feedback highlights a critical stability risk where malformed JSON could crash the cron job and recommends refactoring duplicated parsing and filtering logic into shared helper functions to improve maintainability and error handling.
…ring - Add preferredReleaseGroups and filterByPreferredGroups to userSettings schema - Migration 0008 adds the two new columns to user_settings table - Auto-download now filters candidates to preferred groups before the single/multiple result decision; falls back to all results if no match - Download Started notification includes the release group name - New PreferredReleaseGroupsSettings component with tag input and pre-filter toggle - Settings Rules tab renders the new component - GameDownloadDialog pre-populates selected groups from preferred groups when filterByPreferredGroups is enabled Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…games loop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Wrap JSON.parse of preferredReleaseGroups in try-catch with Array.isArray guard in cron.ts to prevent cron job crash on malformed data - Extract duplicated preferred-groups filter logic into applyPreferredGroupsFilter helper, replacing identical blocks in both wanted-games and owned-games loops - Add console.warn to empty catch block in GameDownloadDialog.tsx - Add Array.isArray guard and console.warn to settings.tsx JSON.parse Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Doezer
force-pushed
the
feat/preferred-release-groups
branch
from
854861a to
6fcbceb
Compare
Owner
Author
|
Add way to add new release group to the list from search download view |
Doezer
commented
Mar 29, 2026
Owner
Author
Doezer
left a comment
Doezer
left a comment
There was a problem hiding this comment.
Addressed all four review comments in commit 45579c2 (rebased onto release/1.3.0):\n\n1. [CRITICAL] cron.ts JSON.parse crash — Wrapped in try-catch with Array.isArray guard; logs a warning on malformed data.\n2. [MEDIUM] Duplicated filter logic — Extracted to applyPreferredGroupsFilter helper; both mainItems and updateItems loops now use it.\n3. [MEDIUM] GameDownloadDialog empty catch — Added console.warn with the error.\n4. [MEDIUM] settings.tsx unsafe cast — Added Array.isArray guard and console.warn in catch.\n\nAll lint, type-check, and tests (659/659) pass.
- Add 9 tests covering applyPreferredGroupsFilter behavior: - Filter multiple results to single preferred-group match - Fallback to all items when no items match preferred groups - Empty array skips filtering - Malformed JSON handled gracefully without crashing - Non-array JSON treated as no filter - Group suffix in Download Started notification - No group suffix when item has no group - Preferred groups applied to owned-game update items - Add mockUpdateGameStatus, mockAddGameDownload, mockAddDownloadWithFallback - Update baseSettings with preferredReleaseGroups, filterByPreferredGroups, steamSyncFailures
Add parseJsonStringArray helper to shared/title-utils.ts and replace the duplicated JSON.parse + Array.isArray + try/catch pattern in cron.ts, settings.tsx, and GameDownloadDialog.tsx. Fixes SonarCloud new_duplicated_lines_density hotspot on PR #491.
- closes dialog after successful download (mockOnOpenChange) - shows destructive toast when API returns success:false - displays indexer errors from search response - shows bundle dialog when main item clicked with updates available - filters results to preferred group when filterByPreferredGroups enabled - shows all results when filterByPreferredGroups is false Also exposes mockToast and mockOnOpenChange for assertion in tests.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…earch tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Doezer
added a commit
that referenced
this pull request
Apr 5, 2026
* feat: add preferred release groups for auto-download and search filtering - Add preferredReleaseGroups and filterByPreferredGroups to userSettings schema - Migration 0008 adds the two new columns to user_settings table - Auto-download now filters candidates to preferred groups before the single/multiple result decision; falls back to all results if no match - Download Started notification includes the release group name - New PreferredReleaseGroupsSettings component with tag input and pre-filter toggle - Settings Rules tab renders the new component - GameDownloadDialog pre-populates selected groups from preferred groups when filterByPreferredGroups is enabled Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor: hoist preferredGroups parsing outside per-game loop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: apply preferred release groups filter to update items in owned-games loop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address Gemini review comments on preferred release groups - Wrap JSON.parse of preferredReleaseGroups in try-catch with Array.isArray guard in cron.ts to prevent cron job crash on malformed data - Extract duplicated preferred-groups filter logic into applyPreferredGroupsFilter helper, replacing identical blocks in both wanted-games and owned-games loops - Add console.warn to empty catch block in GameDownloadDialog.tsx - Add Array.isArray guard and console.warn to settings.tsx JSON.parse Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test: add preferred release groups coverage to cron_autosearch - Add 9 tests covering applyPreferredGroupsFilter behavior: - Filter multiple results to single preferred-group match - Fallback to all items when no items match preferred groups - Empty array skips filtering - Malformed JSON handled gracefully without crashing - Non-array JSON treated as no filter - Group suffix in Download Started notification - No group suffix when item has no group - Preferred groups applied to owned-game update items - Add mockUpdateGameStatus, mockAddGameDownload, mockAddDownloadWithFallback - Update baseSettings with preferredReleaseGroups, filterByPreferredGroups, steamSyncFailures * refactor: extract parseJsonStringArray to eliminate code duplication Add parseJsonStringArray helper to shared/title-utils.ts and replace the duplicated JSON.parse + Array.isArray + try/catch pattern in cron.ts, settings.tsx, and GameDownloadDialog.tsx. Fixes SonarCloud new_duplicated_lines_density hotspot on PR #491. * test: expand GameDownloadDialog coverage with 6 new scenarios - closes dialog after successful download (mockOnOpenChange) - shows destructive toast when API returns success:false - displays indexer errors from search response - shows bundle dialog when main item clicked with updates available - filters results to preferred group when filterByPreferredGroups enabled - shows all results when filterByPreferredGroups is false Also exposes mockToast and mockOnOpenChange for assertion in tests. * refactor: extract createFetchMock helper to eliminate test duplication Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor: extract shared fixtures to reduce duplication in cron autosearch tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Doezer
added a commit
that referenced
this pull request
Apr 9, 2026
* feat: add preferred release groups for auto-download and search filtering - Add preferredReleaseGroups and filterByPreferredGroups to userSettings schema - Migration 0008 adds the two new columns to user_settings table - Auto-download now filters candidates to preferred groups before the single/multiple result decision; falls back to all results if no match - Download Started notification includes the release group name - New PreferredReleaseGroupsSettings component with tag input and pre-filter toggle - Settings Rules tab renders the new component - GameDownloadDialog pre-populates selected groups from preferred groups when filterByPreferredGroups is enabled Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor: hoist preferredGroups parsing outside per-game loop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: apply preferred release groups filter to update items in owned-games loop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address Gemini review comments on preferred release groups - Wrap JSON.parse of preferredReleaseGroups in try-catch with Array.isArray guard in cron.ts to prevent cron job crash on malformed data - Extract duplicated preferred-groups filter logic into applyPreferredGroupsFilter helper, replacing identical blocks in both wanted-games and owned-games loops - Add console.warn to empty catch block in GameDownloadDialog.tsx - Add Array.isArray guard and console.warn to settings.tsx JSON.parse Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test: add preferred release groups coverage to cron_autosearch - Add 9 tests covering applyPreferredGroupsFilter behavior: - Filter multiple results to single preferred-group match - Fallback to all items when no items match preferred groups - Empty array skips filtering - Malformed JSON handled gracefully without crashing - Non-array JSON treated as no filter - Group suffix in Download Started notification - No group suffix when item has no group - Preferred groups applied to owned-game update items - Add mockUpdateGameStatus, mockAddGameDownload, mockAddDownloadWithFallback - Update baseSettings with preferredReleaseGroups, filterByPreferredGroups, steamSyncFailures * refactor: extract parseJsonStringArray to eliminate code duplication Add parseJsonStringArray helper to shared/title-utils.ts and replace the duplicated JSON.parse + Array.isArray + try/catch pattern in cron.ts, settings.tsx, and GameDownloadDialog.tsx. Fixes SonarCloud new_duplicated_lines_density hotspot on PR #491. * test: expand GameDownloadDialog coverage with 6 new scenarios - closes dialog after successful download (mockOnOpenChange) - shows destructive toast when API returns success:false - displays indexer errors from search response - shows bundle dialog when main item clicked with updates available - filters results to preferred group when filterByPreferredGroups enabled - shows all results when filterByPreferredGroups is false Also exposes mockToast and mockOnOpenChange for assertion in tests. * refactor: extract createFetchMock helper to eliminate test duplication Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor: extract shared fixtures to reduce duplication in cron autosearch tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Doezer
added a commit
that referenced
this pull request
Apr 17, 2026
* feat: add preferred release groups for auto-download and search filtering - Add preferredReleaseGroups and filterByPreferredGroups to userSettings schema - Migration 0008 adds the two new columns to user_settings table - Auto-download now filters candidates to preferred groups before the single/multiple result decision; falls back to all results if no match - Download Started notification includes the release group name - New PreferredReleaseGroupsSettings component with tag input and pre-filter toggle - Settings Rules tab renders the new component - GameDownloadDialog pre-populates selected groups from preferred groups when filterByPreferredGroups is enabled Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor: hoist preferredGroups parsing outside per-game loop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: apply preferred release groups filter to update items in owned-games loop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address Gemini review comments on preferred release groups - Wrap JSON.parse of preferredReleaseGroups in try-catch with Array.isArray guard in cron.ts to prevent cron job crash on malformed data - Extract duplicated preferred-groups filter logic into applyPreferredGroupsFilter helper, replacing identical blocks in both wanted-games and owned-games loops - Add console.warn to empty catch block in GameDownloadDialog.tsx - Add Array.isArray guard and console.warn to settings.tsx JSON.parse Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test: add preferred release groups coverage to cron_autosearch - Add 9 tests covering applyPreferredGroupsFilter behavior: - Filter multiple results to single preferred-group match - Fallback to all items when no items match preferred groups - Empty array skips filtering - Malformed JSON handled gracefully without crashing - Non-array JSON treated as no filter - Group suffix in Download Started notification - No group suffix when item has no group - Preferred groups applied to owned-game update items - Add mockUpdateGameStatus, mockAddGameDownload, mockAddDownloadWithFallback - Update baseSettings with preferredReleaseGroups, filterByPreferredGroups, steamSyncFailures * refactor: extract parseJsonStringArray to eliminate code duplication Add parseJsonStringArray helper to shared/title-utils.ts and replace the duplicated JSON.parse + Array.isArray + try/catch pattern in cron.ts, settings.tsx, and GameDownloadDialog.tsx. Fixes SonarCloud new_duplicated_lines_density hotspot on PR #491. * test: expand GameDownloadDialog coverage with 6 new scenarios - closes dialog after successful download (mockOnOpenChange) - shows destructive toast when API returns success:false - displays indexer errors from search response - shows bundle dialog when main item clicked with updates available - filters results to preferred group when filterByPreferredGroups enabled - shows all results when filterByPreferredGroups is false Also exposes mockToast and mockOnOpenChange for assertion in tests. * refactor: extract createFetchMock helper to eliminate test duplication Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor: extract shared fixtures to reduce duplication in cron autosearch tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for users to specify and manage "preferred release groups" for game downloads. Users can now prioritize downloads from specific release groups, both in the UI and in the automatic download logic. The implementation includes database schema changes, UI components for configuration, and backend logic to honor these preferences during searches and downloads.
User Settings and Database Changes:
user_settingstable and schema:preferred_release_groups(a JSON-encoded list of group names) andfilter_by_preferred_groups(a boolean to enable/disable filtering by these groups). [1] [2]Frontend: User Interface for Preferred Groups:
PreferredReleaseGroupsSettingscomponent in the settings page, allowing users to add, remove, and save preferred release groups, as well as toggle filtering. [1] [2] [3] [4] [5]Backend: Auto-Search and Download Filtering:
server/cron.tsto filter both main and update search results by preferred release groups when configured, ensuring only matching releases are considered if any are available. [1] [2] [3]Closes #392