Skip to content

rc1 causes cash-dom crash with rollup.js #5912

@ginlime

Description

@ginlime

Expected Behavior

Works well with rollup.js.

Current Behavior

Console of Chrome shows:

Uncaught ReferenceError: $ is not defined

Console of Firefox also shows:

ReferenceError: $ is not defined

Possible Solution

Keeping lead UMD statement of cash-dom solves this problem:

;(function (root, factory) {
  if (typeof define === "function" && define.amd) {
    define(factory);
  } else if (typeof exports !== "undefined") {
    module.exports = factory();
  } else {
    root.cash = root.$ = factory();
  }
})(this, function () {

Your Environment

  • Version used: rc1
  • Browser Name and version: Chrome 66.0.3359.139, Firefox 61.0b3
  • Operating System and version (desktop or mobile): Windows 7 SP1

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions