Chips style edited: large chips + custom close class#2372
Open
let-aurn wants to merge 2 commits intoDogfalo:masterfrom
let-aurn:master
Open
Chips style edited: large chips + custom close class#2372let-aurn wants to merge 2 commits intoDogfalo:masterfrom let-aurn:master
let-aurn wants to merge 2 commits intoDogfalo:masterfrom
let-aurn:master
Conversation
- Ability to add "large" class to Chips to get them bigger. - Ability to add use different close button component (such as font awesome) by just assign it the "close" class.
giubueno
reviewed
Oct 10, 2018
| } | ||
|
|
||
| i.material-icons { | ||
| .close { |
There was a problem hiding this comment.
I don't follow the logic here. Why did you change the name of the class?
|
This is a really old pull request. Could consider closing it, please? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
largeclass to chips to get them bigger.closeclass.