Slider controls position, and grid options#2857
Open
aviemet wants to merge 5 commits intoDogfalo:masterfrom
Open
Slider controls position, and grid options#2857aviemet wants to merge 5 commits intoDogfalo:masterfrom
aviemet wants to merge 5 commits intoDogfalo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds options for the indicator controls to be in different positions and also changes some grid options.
Slider Changes
The slider init object will now take several more values for the
indicatorsoption:bottom,top,left,right. Only thebelowoption adds the original 40px margin to the bottom of the slider, the rest have the controls nested inside the slider boundaries.Grid Changes
The
$[size]-screen-upvariables were just one above the$[size]-screenvariables, so they don't need to be explicitly set, could allow for strange behavior. Also made them not!defaultfor the same reason.The maximum grid width is something that should be more easily changeable, so I changed that from being hard-coded to being a variable.