Skip to content

Fix issue with the dropdown on mobile#2891

Open
kevinbrink wants to merge 1 commit intoDogfalo:masterfrom
IMRSVDataLabs:fix-mobile-dropdown
Open

Fix issue with the dropdown on mobile#2891
kevinbrink wants to merge 1 commit intoDogfalo:masterfrom
IMRSVDataLabs:fix-mobile-dropdown

Conversation

@kevinbrink
Copy link
Copy Markdown

  • In some circumstances, attempting to scroll within the dropdown on mobile
    would cause the dropdown to disappear immediately, making it impossible to use
    properly. In my particular case, I was re-styling the dropdowns inside a date picker (http://amsul.ca/pickadate.js/, because it offers a few required features that the materialize date picker doesn't) in order to use the materialize dropdowns.

- In some circumstances, attempting to scroll within the dropdown on mobile
  would cause the dropdown to disappear immediately, making it impossible to use
  properly
@JulienMaille
Copy link
Copy Markdown

This works but won't close the dropdown.
I think you need to add this:
#2953

@kevinbrink
Copy link
Copy Markdown
Author

@Nefast : Mind expounding a bit? In my tests, it seems to work fine, and closes the dropdown when I need it to. I see the commit you linked to, as well as the additional code added to that.

When do we want the dropdown to close that my commit doesn't allow for?

@JulienMaille
Copy link
Copy Markdown

Well, if you look at the manual example from a desktop computer, the dropdown will close whenever you click an item: http://materializecss.com/dropdown.html
With your patch it will break this behavio on both desktop and mobile (and fix the scrolling issue on mobile which is nice 👍 )

@kevinbrink
Copy link
Copy Markdown
Author

Ah, ok, I see what you mean now. Our particular application only encountered that particular issue in one area of the app. I see it now though!

@soryy708
Copy link
Copy Markdown

@kevinbrink There are merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants