adjust height of extended fixed nav#4113
Open
lsrock1 wants to merge 1 commit intoDogfalo:masterfrom
lsrock1:master
Open
adjust height of extended fixed nav#4113lsrock1 wants to merge 1 commit intoDogfalo:masterfrom lsrock1:master
lsrock1 wants to merge 1 commit intoDogfalo:masterfrom
lsrock1:master
Conversation
Contributor
Author
|
One more thing, With fixed-nav sidenav doesn't work. sidenav-overlay covers everything. After i change the z-index of fixed-nav 997 to 998, it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem: when i want to use fixed navbar with Extended Navbar with Tabs,
tab contents are covered by tab buttons because .navbar-fixed's height is just set to $navbar-height or $navbar-height-mobile without tab's height. (content's div tag goes up to bottom of navbar)
code: http://codepen.io/anon/pen/egBqZR
So i make new class, navbar-extended-fixed. Its height is set $ navbar-height + $tabs-height to widen the height and cover all the tab area.
In variables.scss file i add new variable, $tabs-height to reflect tab's change automatically because tabs-height is accessed in navbar and there is a possibility that some tab's changes in the future breaks nav'css
This tag can be used exactly same way like navbar-fixed.
after code: http://codepen.io/anon/pen/mRONQy