add show-on-* classes for display inline, inline-block, flex, inline-…#5055
Open
florianrubel wants to merge 2 commits intoDogfalo:masterfrom
florianrubel:show-inline-flex-classes
Open
add show-on-* classes for display inline, inline-block, flex, inline-…#5055florianrubel wants to merge 2 commits intoDogfalo:masterfrom florianrubel:show-inline-flex-classes
florianrubel wants to merge 2 commits intoDogfalo:masterfrom
florianrubel:show-inline-flex-classes
Conversation
Author
|
I forgot to update the documentation. Shame on me. Will do right now. |
Author
|
done |
Contributor
|
That is just too much. No other frameworks do it like this. |
Author
|
Sure. Bootstrap does. But without flex. Only inline, inline-block and block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…flex
Proposed changes
The CSS classes
.show-on-*like.show-on-medium-and-upwill always lead to adisplay: blockbut that's not always what you want.I added classes for .show-on-* to make them supporting inline-block, inline, flex, inline-flex with the following pattern:
Screenshots (if appropriate) or codepen:
Codepen: https://codepen.io/anon/pen/ayZrMP
Types of changes
Checklist: