Skip to content

add show-on-* classes for display inline, inline-block, flex, inline-…#5055

Open
florianrubel wants to merge 2 commits intoDogfalo:masterfrom
florianrubel:show-inline-flex-classes
Open

add show-on-* classes for display inline, inline-block, flex, inline-…#5055
florianrubel wants to merge 2 commits intoDogfalo:masterfrom
florianrubel:show-inline-flex-classes

Conversation

@florianrubel
Copy link
Copy Markdown

@florianrubel florianrubel commented Aug 2, 2017

…flex

Proposed changes

The CSS classes .show-on-* like .show-on-medium-and-up will always lead to a display: block but that's not always what you want.

I added classes for .show-on-* to make them supporting inline-block, inline, flex, inline-flex with the following pattern:

.show-on-(screensize)-(display-property)
// f.e.
.show-on-small-inline-block

Screenshots (if appropriate) or codepen:

Codepen: https://codepen.io/anon/pen/ayZrMP

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@florianrubel
Copy link
Copy Markdown
Author

I forgot to update the documentation. Shame on me.

Will do right now.

@florianrubel
Copy link
Copy Markdown
Author

done

@DanielRuf
Copy link
Copy Markdown
Contributor

That is just too much. No other frameworks do it like this.

@florianrubel
Copy link
Copy Markdown
Author

Sure. Bootstrap does. But without flex. Only inline, inline-block and block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants