Using Sass Placeholders for proper use of @extend#5080
Open
digitalkaoz wants to merge 1 commit intoDogfalo:masterfrom
Open
Using Sass Placeholders for proper use of @extend#5080digitalkaoz wants to merge 1 commit intoDogfalo:masterfrom
digitalkaoz wants to merge 1 commit intoDogfalo:masterfrom
Conversation
Contributor
|
There is an error. Please keep an eye on the tests. |
Author
|
@DanielRuf fixed it, creating PRs through the github is not always cool ;) |
this PR exposes all grid related class (`.row`, `.col`, `s1-12`, `m1-12`, `l1-12`) als Sass Placeholders: `%row`, `%l17`... see this http://12devs.co.uk/articles/semantic-grids-with-sass-loops-and-silent-placeholders/ for a proper explanation this avoids extremly large selector chains when using the materialize grid classes in your sass files: ```sass .my-row { @extend %row; .my-col { @extend %col; &.s7 { @extend %s7; } } } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR exposes all grid related class (
.row,.col,s1-12,m1-12,l1-12) as Sass Placeholders:%row,%l17...see this http://12devs.co.uk/articles/semantic-grids-with-sass-loops-and-silent-placeholders/ for a proper explanation
this avoids extremely large selector chains when using the materialize grid classes in your sass files:
Types of changes
Checklist: