Skip to content

Fixed nesting tabs bug#5090

Open
penguoir wants to merge 1 commit intoDogfalo:masterfrom
penguoir:5087
Open

Fixed nesting tabs bug#5090
penguoir wants to merge 1 commit intoDogfalo:masterfrom
penguoir:5087

Conversation

@penguoir
Copy link
Copy Markdown

@penguoir penguoir commented Aug 9, 2017

When using the URL to pre-select a nested tab, activate that tab's parent tab. #5087

Proposed changes

With nested tabs, activate the parent tab if the nested tab is active through the URL.

Screenshots (if appropriate) or codepen:

Example

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

When using the URL to pre-select a nested tab, activate that tab's parent tab. #5087
@penguoir
Copy link
Copy Markdown
Author

penguoir commented Aug 9, 2017

Does the documentation require the use of nested tabs?

@penguoir
Copy link
Copy Markdown
Author

penguoir commented Aug 9, 2017

Also, should there be tests for this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant