feat: add optional filter input to component:select

[ahwayakchih]

Proposed changes

In case of long list of options in select field, it might be easier to quickly filter items by text. While current v1-dev branch does contain some filtering, it's not as helpful visually for users.

This change adds optional (available only when data-filtered="placeholder text" attribute is set on select element) input field, that allows user to see what he or she enters while trying to filter the list of items.
Additionally, items that do not match the text become hidden (class hide is added on li elements).

Changes were sponsored by Egmont Group.

Screenshots (if appropriate) or codepen:

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[charbelsako]

Hi, quick question do i actually have to make the feature i want to request?

[Dogfalo]

No

On Sat, May 26, 2018 at 2:39 PM Charbel Sarkis ***@***.***> wrote: Hi, quick question do i actually have to make the feature i want to request? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5943 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACpax_VTn5cU0HzteXajlE01UgO4wuP0ks5t2cudgaJpZM4UMDjn> .

-- Doggy sends his greetings from Mars.

[charbelsako]

Great. Can you add custom validation. Exactly like the validation class but
the user can supply an attribute data-regex to tell it when to succeed and fail.

[Dogfalo]

This sounds like a separate request. Please create a new issue for it

On Sat, May 26, 2018 at 2:48 PM Charbel Sarkis ***@***.***> wrote: Great. Can you add custom validation. Exactly like the validation class but the user can supply an attribute data-regex to tell it when to succeed and fail. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5943 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACpax3_unt3qZf_b18lxeyeT590wcOJZks5t2c2zgaJpZM4UMDjn> .

-- Doggy sends his greetings from Mars.

[charbelsako]

Just did. #5945

[ahwayakchih]

@Dogfalo hi, now that totally off topic stuff has been resolved, is there any chance for a comment about the pull request :)? Does it need more changes in code to be accepted, or maybe it won't be accepted because it adds too big of a change, or complicates component a bit, or... ?

[Dogfalo]

We're not adding any more features right now since we're in release candidate build

[ahwayakchih]

@Dogfalo thanks for the answer. Do you think this feature could be merged post-1.0 release?

[Dogfalo]

Yes, it seems useful and code is organized

[ahwayakchih]

Great! Thanks.

[ahwayakchih]

@Dogfalo i updated to latest dev branch and fixed test. Any chance it could be merged now?

[ahwayakchih]

@Dogfalo @acburst any chance this could be merged? If not, i can just close this and stop wasting your time :).

[Smankusors]

Hmm if you want, you can send your pull request to the forked one instead https://github.com/materializecss/materialize 😉