Skip to content

chore: Align auth page with CLI icon#18

Merged
amix merged 1 commit into
mainfrom
amix/auth-success-page-colors
Jun 5, 2026
Merged

chore: Align auth page with CLI icon#18
amix merged 1 commit into
mainfrom
amix/auth-success-page-colors

Conversation

@amix
Copy link
Copy Markdown
Member

@amix amix commented Jun 5, 2026

Context

The auth callback page used teal accents and the inline SVG logo could render too blue because its blend modes interacted with the page backdrop.

What was changed

  • Align success page accents with the CLI icon lavender and ink palette.
  • Isolate the inline SVG logo so its blend modes render against the icon container.

@amix amix requested a review from scottlovegrove June 5, 2026 13:25
@amix amix marked this pull request as ready for review June 5, 2026 13:25
@amix amix added the 👀 Show PR PR must be reviewed before or after merging label Jun 5, 2026
@amix amix merged commit 09aaf0f into main Jun 5, 2026
7 checks passed
@amix amix deleted the amix/auth-success-page-colors branch June 5, 2026 13:26
Copy link
Copy Markdown
Member

@doistbot doistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amir for updating the auth callback page styling to align with the CLI icon palette and fixing the SVG blend modes 🤗. No issues were flagged.

I also included a few optional follow-up notes in the details below.

Optional follow-up notes (2)
  • [P3] src/lib/auth-pages.ts:174: These new palette literals duplicate the fills already hardcoded inside COMMS_CLI_ICON_SVG, which is how this page ended up drifting from the icon in the first place. Hoist the ink/lavender values into module-level constants and interpolate them into both the SVG string and the page CSS so future palette changes stay aligned.
  • [P3] src/lib/auth-pages.ts:230: This PR fixes a specific rendering regression by isolating the logo container, but the nearby auth login wiring test still only checks the page copy. Since src/commands/auth/auth.test.ts already calls both options.renderSuccess() and options.renderError(), add a regression assertion that the generated HTML includes the logo isolation rule (and the matching error-page change) so a future style cleanup doesn't silently bring back the blend-mode color shift.

Share FeedbackReview Logs

@doist-release-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released 👀 Show PR PR must be reviewed before or after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants