Skip to content

feat: Add channel create and update#4

Merged
amix merged 1 commit into
mainfrom
amix/channel-create-update
May 25, 2026
Merged

feat: Add channel create and update#4
amix merged 1 commit into
mainfrom
amix/channel-create-update

Conversation

@amix
Copy link
Copy Markdown
Member

@amix amix commented May 25, 2026

Context

  • Adds channel creation and metadata updates to tdc channel.
  • Keeps delete support intentionally out of scope.
  • Updates the installed agent skill reference for the new command surface.

What was changed

  • Added tdc channel create with workspace, description, initial users, public/private, dry-run, JSON, and full output support.
  • Added tdc channel update for rename, description update/clear, visibility, dry-run, JSON, and full output support.
  • Shared name validation and direct/numeric ref helpers so channel behavior stays consistent with existing ref parsing.

Out of scope

  • Channel delete support.

Refs

@amix amix requested review from hfauq and scottlovegrove May 25, 2026 07:38
@amix amix added the 👀 Show PR PR must be reviewed before or after merging label May 25, 2026
@amix amix marked this pull request as ready for review May 25, 2026 07:38
@amix amix requested a review from doistbot May 25, 2026 07:38
Copy link
Copy Markdown
Member

@doistbot doistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR successfully expands the CLI by introducing the tdc channel create and tdc channel update commands with robust flag support and shared validation logic. These additions significantly enhance the tool's channel management capabilities while keeping referencing behavior consistent. There are just a few adjustments to make regarding name validation edge cases, shifting an ID parsing optimization to a shared helper, ensuring JSON outputs include modified fields, skipping unnecessary network calls during dry runs, and updating test coverage along with agent skill examples to meet internal PII standards.

Share FeedbackReview Logs

Comment thread src/commands/channel/helpers.ts
Comment thread src/lib/skills/content.ts Outdated
Comment thread src/commands/channel/create.ts Outdated
Comment thread src/commands/channel/update.ts Outdated
Comment thread src/lib/refs.ts
Comment thread src/commands/channel/update.ts
Comment thread src/commands/channel/channel.test.ts Outdated
Comment thread src/commands/channel/channel.test.ts
Comment thread src/lib/refs.test.ts
Comment thread src/lib/skills/content.ts Outdated
@amix amix force-pushed the amix/channel-create-update branch from b0cc003 to dc36f99 Compare May 25, 2026 07:48
@amix amix merged commit f097378 into main May 25, 2026
5 checks passed
@amix amix deleted the amix/channel-create-update branch May 25, 2026 07:50
Copy link
Copy Markdown
Collaborator

@scottlovegrove scottlovegrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

doist-release-bot Bot added a commit that referenced this pull request May 25, 2026
## 1.0.0 (2026-05-25)

### Features

* add channel create and update commands ([#4](#4)) ([f097378](f097378))
* adopt cli-core DCR provider + account command attachers ([#5](#5)) ([4749a07](4749a07))
* bootstrap Comms CLI from twist-cli ([ea28735](ea28735))
* upgrade to @doist/comms-sdk@0.2.0 ([#2](#2)) ([ae4d6e1](ae4d6e1))
@doist-release-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released 👀 Show PR PR must be reviewed before or after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support a channel creation command

3 participants