Skip to content

feat: Run doist-os setup script from Windows bootstrap#1

Merged
scottlovegrove merged 2 commits intomainfrom
scottl/windows-bootstrap-run-setup
Apr 3, 2026
Merged

feat: Run doist-os setup script from Windows bootstrap#1
scottlovegrove merged 2 commits intomainfrom
scottl/windows-bootstrap-run-setup

Conversation

@scottlovegrove
Copy link
Copy Markdown
Collaborator

Summary

  • Windows bootstrap now calls scripts/setup.ps1 from the cloned doist-os repo after cloning, matching the macOS bootstrap behavior
  • Removes the "not implemented yet" message and agent app guidance (now handled by the setup script itself, see Doist/doist-os#86)

Test plan

  • Run the Windows bootstrap and verify it clones the repo then invokes scripts/setup.ps1
  • Verify failure is reported clearly if scripts/setup.ps1 is missing or exits non-zero

🤖 Generated with Claude Code

The Windows bootstrap now calls scripts/setup.ps1 from the cloned
doist-os repo after cloning, matching the macOS bootstrap behavior.
Previously it just printed a message saying Windows setup was not
implemented.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@scottlovegrove scottlovegrove self-assigned this Apr 3, 2026
@doistbot doistbot requested a review from rmartins90 April 3, 2026 12:13
Copy link
Copy Markdown
Member

@doistbot doistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR nicely aligns the Windows bootstrap process with macOS by automatically invoking the setup script after cloning and cleaning up outdated manual guidance. These changes will help streamline the onboarding experience for Windows users by centralizing the setup logic. A couple of minor adjustments are noted to ensure the setup script executes reliably from the repository root and to clean up a newly orphaned guidance function.

Share FeedbackReview Logs

Address review feedback:
- Push-Location into the repo root before running the setup script,
  matching the macOS bootstrap behavior (cd into $TARGET_DIR)
- Remove orphaned Print-AgentAppGuidance function (now handled by the
  doist-os setup script)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@scottlovegrove scottlovegrove merged commit a739c38 into main Apr 3, 2026
@scottlovegrove scottlovegrove deleted the scottl/windows-bootstrap-run-setup branch April 3, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants