fix: secure config permissions and address update channel review feedback#53
Merged
scottlovegrove merged 3 commits intomainfrom Apr 2, 2026
Merged
fix: secure config permissions and address update channel review feedback#53scottlovegrove merged 3 commits intomainfrom
scottlovegrove merged 3 commits intomainfrom
Conversation
…, --check display Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that next.10 is treated as newer than next.2, preventing reintroduction of the lexicographic comparison bug. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
doistbot
reviewed
Apr 2, 2026
Member
doistbot
left a comment
doistbot
left a comment
There was a problem hiding this comment.
This PR improves the application's security by applying stricter permissions to the configuration file, alongside refining the version checker to correctly display downgrade options. These updates enhance both user data safety and the clarity of update messaging. However, an explicit permission update may be needed to ensure these tighter restrictions reliably apply to existing configuration files as well as other functions that modify the configuration.
- Add explicit chmodSync(0o600) after writeFileSync to enforce permissions on existing files (mode only applies to new files) - Use "Downgrade available" instead of "Note: older than" for consistent phrasing between --check and normal update paths Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
scottlovegrove
requested review from
a team and
pauloslund
and removed request for
a team
doist-release-bot Bot
added a commit
that referenced
this pull request
Apr 2, 2026
## [1.5.1](v1.5.0...v1.5.1) (2026-04-02) ### Bug Fixes * secure config permissions and address update channel review feedback ([#53](#53)) ([63e64f8](63e64f8))
Contributor
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setUpdateChannelnow creates the config directory with0o700and writesconfig.jsonwith0o600to prevent other users from reading sensitive config--checkdowngrade display: The--checkpath now has a proper three-way branch distinguishing "up to date", "update available", and "downgrade available" (previously a downgrade showed as "up to date")Note: The prerelease
localeComparefix andprocess.argv[1]fallback were already present in the merged code, so no changes were needed for those.Test plan
npm run type-checkpassesnpm test)npm run lint:checkpasses (0 warnings, 0 errors)🤖 Generated with Claude Code