Skip to content

chore(deps): extend tsconfig from @doist/tsconfig#32

Merged
frankieyan merged 1 commit intomainfrom
frankieyan/use-doist-tsconfig
Jan 21, 2026
Merged

chore(deps): extend tsconfig from @doist/tsconfig#32
frankieyan merged 1 commit intomainfrom
frankieyan/use-doist-tsconfig

Conversation

@frankieyan
Copy link
Copy Markdown
Member

Summary

  • Add @doist/tsconfig as a dev dependency
  • Update tsconfig.json to extend from @doist/tsconfig
  • Remove redundant strict: true (inherited from base config)

Test plan

  • npm run check:types passes
  • npm run build succeeds
  • npm test passes (55 tests)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@frankieyan frankieyan requested a review from a team as a code owner January 21, 2026 02:21
@frankieyan frankieyan requested review from scottlovegrove and removed request for a team January 21, 2026 02:21
Copy link
Copy Markdown

@doistbot-app doistbot-app Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR correctly adds the @doist/tsconfig dependency and extends it in tsconfig.json. However, there are consistent indentation inconsistencies across the modified files (package.json, package-lock.json, and tsconfig.json), which suggests the files may have been manually edited rather than updated via tooling. The package-lock.json should be regenerated to ensure integrity.

Comment thread package-lock.json
Comment thread package.json
Comment thread tsconfig.json
@frankieyan frankieyan added the 👀 Show PR PR must be reviewed before or after merging label Jan 21, 2026
@frankieyan frankieyan merged commit eba54c3 into main Jan 21, 2026
2 checks passed
@frankieyan frankieyan deleted the frankieyan/use-doist-tsconfig branch January 21, 2026 02:45
Copy link
Copy Markdown

@scottlovegrove scottlovegrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR PR must be reviewed before or after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants