fix: remove deleted files from records file with --stage-record-file
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using --stage-record-file, deleted files are now automatically
removed from the records instead of throwing an error. This enables
pre-commit hooks to include deleted files (diff-filter=ACMRD) so the
tracker can clean up records for removed files.
- Add partitionByExistence() to separate existing/deleted files
- Update --stage-record-file to compile only existing files while
passing all files to records for cleanup
- Add log messages for deleted files being removed
- Fix grammar in log messages ("1 file" vs "1 files")
- Update README with new behavior and diff-filter guidance
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
frankieyan
changed the title
![doist-bot[bot]](https://avatars.githubusercontent.com/in/2345791?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR correctly implements the extraction of the pluralize helper and handles the logic for deleted files in the records staging process. The implementation of partitionByExistence and the corresponding logic in runStageRecords handles file partitioning effectively. The test coverage is adequate for the new functionality.
frankieyan
changed the title
--stage-record-file
Pass existingFilePaths instead of allFilePaths to exitIfErrorsIncreased since only existing files are compiled. Deleted files are handled separately and don't need error checking. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
When using
--stage-record-file, deleted files are now automatically removed from the records instead of throwing an error. This enables pre-commit hooks to include deleted files (diff-filter=ACMRD) so the tracker can clean up records for removed files.Test plan
npm run buildsrc/__fixtures__/sample-project/src, and runnode dist/index.mjs --overwriteto add it to recordsbad-component.tsx)node dist/index.mjs --stage-record-file src/__fixtures__/sample-project/src/<yourfile.tsx>npx react-compiler-tracker --check-file src/__fixtures__/sample-project/src/<yourfile.tsx>exits with "No file found"