Skip to content

chore: Add renovate.json#4

Merged
frankieyan merged 1 commit intomainfrom
frankie/renovate
Jan 10, 2026
Merged

chore: Add renovate.json#4
frankieyan merged 1 commit intomainfrom
frankie/renovate

Conversation

@frankieyan
Copy link
Copy Markdown
Member

Ref: #1

Copy link
Copy Markdown

@doistbot-app doistbot-app Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR correctly adds a Renovate configuration file to automate dependency updates. The configuration is well-structured, extending a shared preset. I have one minor suggestion to improve the readability of the PR notes generated by Renovate, but the change is functionally sound.

Comment thread renovate.json
"updateNotScheduled": false,
"reviewers": ["team:frontend-product"],
"prBodyNotes": [
"## Reference\n",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Combine prBodyNotes for improved clarity and formatting

For better readability of both this configuration file and the rendered PR body, consider combining the prBodyNotes array elements into a single string. This also allows for adding a newline for better visual separation in the final PR description.

Suggested change
"## Reference\n",
"## Reference\n\n - See [Keeping dependencies up-to-date](https://handbook.doist.com/doc/keeping-dependencies-up-to-date-Qf28E929N5) for reviewing guidelines."

@frankieyan frankieyan added the 👀 Show PR PR must be reviewed before or after merging label Jan 10, 2026
@frankieyan frankieyan merged commit 3ef870f into main Jan 10, 2026
2 checks passed
@frankieyan frankieyan deleted the frankie/renovate branch January 10, 2026 04:54
@frankieyan frankieyan requested review from a team and nats12 and removed request for a team January 10, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR PR must be reviewed before or after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant