build: Add publishing workflows#8
Conversation
![doistbot-app[bot]](https://avatars.githubusercontent.com/in/2345791?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request successfully introduces workflows for release automation and package publishing. However, there are a few critical issues that need to be addressed for the process to function correctly. A misconfiguration in package.json will cause publishing to fail, and the release workflow is set up to trigger the publishing job twice. Additionally, a minor improvement for stability in the publish workflow is recommended.
| scope: '@doist' | ||
|
|
||
| - name: Ensure npm 11.5.1 or later is installed | ||
| run: npm install -g npm@latest |
There was a problem hiding this comment.
[P3] Use a specific npm version range for stability.
Using npm@latest could cause this workflow to fail unexpectedly if a new major version of npm with breaking changes is released. To ensure stability and align with the step name, it's better to pin to a specific version range.
| run: npm install -g npm@latest | |
| run: npm install -g npm@^11.5.1 |
There was a problem hiding this comment.
We do the same thing in Reactist. Let's leave this for now.
frankieyan
force-pushed
the
frankie/release-flow
branch
from
a5f2464 to
02c30d1
Compare
frankieyan
force-pushed
the
frankie/release-flow
branch
from
02c30d1 to
c9c15f4
Compare
frankieyan
requested review from
a team and
gnapse
and removed request for
a team
2 participants
This adds the workflows for release-please and to publish the package to the GitHub packages registry.