feat!: require node >=24, test on 24 & 26, support npm >=11#1098
Merged
Conversation
Node 20 has reached end-of-life. Raise the minimum supported node to 24, add explicit node 26 coverage via a CI test matrix, and declare npm >=11. BREAKING CHANGE: minimum node is now 24; node 20 and 22 are no longer supported.
doistbot
reviewed
Jul 16, 2026
doistbot
left a comment
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR raises the minimum Node.js version to 24, adds an engines block requiring Node ≥24 and npm ≥11, and updates the test workflow to run a CI matrix on Node 24 and 26.
Few things worth tightening:
- The
node_modulescache key doesn't include the matrix Node version, so the Node 24 and Node 26 jobs will share the same key and could restore anode_modulesinstalled under a different runtime. Adding${{ matrix.node-version }}to the cache key would isolate them.
Address doistbot review.
Contributor
Author
|
This needs an update to todoist-web first as that's still on node 22. |
# Conflicts: # .github/workflows/pull_request.yml
Main consolidated CI into check-ci-validation.yml. Rather than run every job (lint, build, prepare) twice, scope the [24, 26] matrix to the unit-testing job where the runtime version actually matters; the other jobs stay on the single .node-version baseline.
The [24,26] matrix renamed the reported context to 'Unit Testing (24)'/'(26)', so the branch ruleset's required 'Unit Testing' context was never reported and blocked merges. Rename the matrix job and add a gate job named 'Unit Testing' that succeeds once the matrix passes, giving a single stable required context.
Contributor
Author
This has now been taken care of. |
scottlovegrove
requested review from
a team and
pawelgrimm
and removed request for
a team
July 16, 2026 19:50
scottlovegrove
added
the
👀 Show PR
Contributor
|
🎉 This PR is included in version 35.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node 20 has reached end-of-life, so this raises the minimum supported Node.js version to 24. As Reactist is a published library, the
enginesbump is a genuine breaking change for consumers on older Node versions.Changes
.node-version:22.22→24package.jsonengines: addednode: ">=24"andnpm: ">=11"(no engines block previously existed).github/workflows/pull_request.yml(test workflow): now runs a CI matrix testing on Node 24 and 26, replacing the singlenode-version-file: .node-versionwithnode-version: ${{ matrix.node-version }}The
publish.yml,chromatic.yml, anddeploy-storybook.ymlworkflows continue to use the single.node-versionfile (now 24) and are intentionally not matrixed.Breaking change
Minimum Node.js is now 24; Node 20 and 22 are no longer supported.