Only add menu list to DOM if menu is visible#402
Merged
Conversation
Contributor
Author
|
CodeQL fails because of an inefficient regex in the vendor bundle of storybook 🙃 going to disable it another PR |
gnapse
approved these changes
Dec 1, 2020
Contributor
gnapse
left a comment
gnapse
left a comment
There was a problem hiding this comment.
Disclaimer: haven't tried it. But looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
We've noticed some performance problems in Twist on large conversations where a lot of message would each render their full menu list into the DOM only to hide it until it's accessed. This PR should circumvent this by only rendering the menu list once the menu is opened.
It's enough to review 86efa27, the other commit is the result of bumping the version, updating the changelog and building assets
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonnpm run build-all)Versioning
patch, see CHANGELOG update