fix: Loading component no longer spins off-centre#474
Merged
frankieyan merged 4 commits intodevfrom Mar 22, 2021
Merged
Conversation
craigcarlyle
changed the title
craigcarlyle
requested review from
a team and
gnapse
and removed request for
a team
Contributor
Author
|
cc: @scottlovegrove for visibility 👀 |
Member
|
Released under v9.1.1 and v9.2.0-beta.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Fixes an issue where the Loading component would spin off-centre
PR Checklist
npm run validateand made sure no errors / warnings were shownnpm run build-all)Test Plan
Demo
before.mov
after.mov