refactor: Change deprecated way to import React #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nats12
approved these changes
Sep 7, 2022
Contributor
nats12
left a comment
nats12
left a comment
There was a problem hiding this comment.
Looks good 👍🏼 from the thread's poll we may need to change this again in the near future though to named imports.
Contributor
Author
The poll seems to have the wildcard import winning. But even if it did not, making the move to named imports is not easily achievable via search and replace. It may need a codemod script or something like that. In the meantime, we move away from the default React import that's deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
Test plan
Not really anything to test, but I still want explicit approval.