Merged
Conversation
gnapse
force-pushed
the
ernesto/more-ariakit-upgrade-fixes
branch
from
f9bb117 to
354f53f
Compare
6 tasks
nats12
pushed a commit
that referenced
this pull request
May 31, 2024
* Remove hack to hide tooltips when clicking to dismiss a button popover * Simplify Menu's onItemSelect handling internally * Hide menus when they lose focus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
The changes here fix two issues we detected while attempting to upgrade to this version of Reactist and the new Ariakit in todoist-web:
🟠 Opening the settings via keyboard while a menu is expanded, keeps the menu on top of the settings modal (https://share.cleanshot.com/SjvnsDLz)
Screen recording
CleanShot.202024-02-16.20at.2014.00.26.mp4
🟠 Clicking with the mouse outside a tooltip to dismiss it and then hovering buttons will keep the tooltips rendered indefinitely (https://share.cleanshot.com/Y4mt2xWT)
Screen recording
CleanShot.202024-02-16.20at.2014.14.15.mp4
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) ref