Skip to content

Conversation

@frankieyan
Copy link
Member

@frankieyan frankieyan commented Dec 14, 2024

Short description

Following up from #851, this adds top/bottom paddings to the tabs so that they render at the same height as before the line-height change. Paddings are used over min-height so that they remain consistent even if multiple lines of text are rendered in the tabs.

Before After
image image
image image

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Patch

@frankieyan frankieyan added the 👀 Show PR Used for PRs that need a review, but can be merged when CI is green. label Dec 14, 2024
@frankieyan frankieyan requested a review from henningmu December 14, 2024 05:00
@frankieyan frankieyan merged commit 3594542 into main Dec 14, 2024
5 checks passed
@frankieyan frankieyan deleted the frankie/fix-tab-height branch December 14, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR Used for PRs that need a review, but can be merged when CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants