ci: implement release-please to automate release creation #863
+93
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartins90
commented
Jan 19, 2025
rmartins90
commented
Jan 19, 2025
rmartins90
commented
Jan 19, 2025
henningmu
reviewed
Jan 20, 2025
Contributor
henningmu
left a comment
henningmu
left a comment
There was a problem hiding this comment.
Thank you for doing this, Rui 👏
Can you please add the action that enforces semantic PR titles to this PR (copy from todoist-web)?
Do you think we should mention that releases / versioning is done based on semantic commits (PR titles) in the PULL_REQUEST_TEMPLATE?
Contributor
Author
Absolutely. Just did.
Same 🙂 Can you please review again? |
rmartins90
commented
Jan 20, 2025
henningmu
approved these changes
Jan 21, 2025
Contributor
henningmu
left a comment
henningmu
left a comment
There was a problem hiding this comment.
Looks great 👏
Left some minor comments, but I don't need to see this again 🙌
6 tasks
Contributor
|
|
This was referenced Jan 21, 2025
gnapse
added a commit
to Doist/todoist-ai
that referenced
this pull request
Aug 12, 2025
This is a blatant copy of Doist/reactist#863, hence my targeted review request for Rui. I guess I now have to configure the secrets (`GITHUB_TOKEN` and `NPM_TOKEN`), which I'm not sure where to get from.⚠️ **Also, please know that this repository may eventually be public, so avoid discussing anything sensitive here.** Is this all it takes? Will this work out-of-the-box after that is configured and this gets merged? Or is there something else to be done? ~~For instance, if I merge this before #5, and then I merge that PR, will that trigger the v0.2.0 release? _(Because it's a `feat` I assume it will increase in that way, but I'm not sure about semver on v0.x which behaves differently; but you get my point.)_~~ I forgot that I merged #5 beforehand, so now I do not have a pull request with which to test this. But I still need to get the changes in #5 released. What do you think I should do? Release those changes first manually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR implements automated releases using Google's release-please GitHub Action. Automating version bumping, changelog management, and release creation will streamline our release process.
Before:
After:
Migration Note
Existing CHANGELOG.md content should be preserved. Release-please manages new entries while maintaining the historical changelog. But this needs to be validated further in the first release PR.
Changes
How it works
feat:,fix:, etc.)main, release-please:PR Checklist