refactor: integrate @doist/cli-core 0.6.0 (markdown + changelog) by scottlovegrove · Pull Request #319 · Doist/todoist-cli

scottlovegrove · 2026-05-09T08:25:18Z

Summary

Markdown rendering — src/lib/markdown.ts now delegates preloadMarkdown / renderMarkdown to @doist/cli-core/markdown, keeping the local leading-* bullet escape (uncompletable task prefix) on top. Drops the local marked-terminal-renderer ambient .d.ts shim now that cli-core owns the typing.
Changelog command — src/commands/changelog.ts is now a thin wrapper over registerChangelogCommand from @doist/cli-core/commands, passing path, repoUrl, and version. cli-core defaults match prior behavior (heading 2, * bullets, no continuation indent, no empty-version filtering). Local test deleted — cli-core covers the behavior.
Top-level error handler — src/index.ts now matches instanceof BaseCliError (cli-core class) so errors thrown from cli-core commands route through the existing formatError path. The local CliError extends base, so subclass throws still match. formatError / formatErrorJson widened accordingly.
Bumps @doist/cli-core from 0.5.0 to 0.6.0.

Test plan

npm run check (oxlint + oxfmt)
npx tsc --noEmit
npm test (1578 tests, 6 changelog tests removed alongside the local impl — covered by cli-core)
Smoke td changelog -n 1 — output unchanged
Smoke td changelog -n abc — error routes via cli-core CliError(INVALID_TYPE) through todoist's top-level handler

🤖 Generated with Claude Code

Wraps the upcoming cli-core markdown module (preloadMarkdown + renderMarkdown) and keeps the local "* " bullet-escape for uncompletable task prefixes. Drops the marked-terminal-renderer ambient .d.ts shim now that cli-core owns the typing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Replace the local changelog command implementation with a thin wrapper over registerChangelogCommand from @doist/cli-core/commands, passing the todoist-specific path, repo URL, and version. cli-core defaults match the prior behavior (heading 2, `*` bullets, no continuation indent). Top-level error handler now matches against the cli-core base CliError so errors thrown from cli-core commands route through the existing formatError path; the local CliError extends base, so subclass throws still match. formatError / formatErrorJson widened accordingly. Local changelog tests removed — cli-core covers the behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Picks up the released ./markdown and ./commands subpaths consumed by src/lib/markdown.ts and src/commands/changelog.ts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

doistbot

This PR successfully integrates @doist/cli-core 0.6.0 to standardize markdown rendering and the changelog command while thoughtfully reducing local boilerplate. Transitioning these features to the shared package improves long-term maintainability by letting the core module handle the heavy lifting. A few adjustments are needed to fully align the integration, such as centralizing the new core error types within our local abstraction, preserving slim integration coverage for the changelog wiring, synchronizing markdown preload behavior, and updating both test coverage and repository documentation to reflect the structural changes.

_{Share Feedback • Review Logs}

- markdown wrapper: replace dual-source preload flag with a cached preload promise — single source of truth for readiness, can't drift from cli-core's own state. - errors: re-export `BaseCliError` from `src/lib/errors.ts` so the top-level handler in `src/index.ts` and the formatter widening in `src/lib/output.ts` consume cli-core's error class through the local abstraction instead of importing `@doist/cli-core` in two places. - changelog: re-add a slim integration test exercising the wrapper's todoist-specific path / repoUrl / version wiring. - output.test: cover `formatError` / `formatErrorJson` against a real cli-core `CliError` instance so the new formatter path can't regress. - AGENTS.md / CODEBASE.md: drop the removed `src/types/` entry from the repo map and document that the global error handler also matches the re-exported `BaseCliError`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

doist-release-bot · 2026-05-09T10:19:02Z

🎉 This PR is included in version 1.62.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

rfgamaral

✅

## Summary - **Changelog command** — `src/commands/changelog.ts` is now a thin wrapper over `registerChangelogCommand` from `@doist/cli-core/commands`, passing `path`, `repoUrl`, `version`, and `bulletMarkers: ['*', '-']` (preserves outline's local support for both bullet styles). Drops ~110 lines of local parsing/formatting now owned by cli-core. - **Top-level error handler** — `src/index.ts` now matches `instanceof BaseCliError` so errors thrown from cli-core helpers (e.g. the delegated `changelog` command's `INVALID_TYPE` / `FILE_READ_ERROR`) route through `formatError` / `formatErrorJson`. The local `CliError` extends the same base, so existing throws still match. - **Global JSON flag** — declared `--json` and `--ndjson` at the program level with `enablePositionalOptions()`, plus an `isJsonMode()` helper in `src/lib/global-args.ts` backed by cli-core's `parseGlobalArgs` argv scan. `ol --json <subcommand>` now produces a JSON error envelope for any `BaseCliError` thrown after parsing. - **`formatError` / `formatErrorJson`** — widened in `src/lib/output.ts` to accept either positional `(code, message, hints?)` or a `BaseCliError` instance. - **`src/lib/errors.ts`** — re-exports `CoreCliError` as `BaseCliError` so the top-level `instanceof` check covers both. Mirrors [todoist-cli#319](Doist/todoist-cli#319). No `@doist/cli-core` version bump (already on `0.9.0`). ## Behavior changes - `ol changelog -n abc` now exits non-zero with `Error: INVALID_TYPE / Count must be a positive integer` (was a custom `chalk.red('Error:')` line with `Count must be a positive number`) — intentional alignment with the cli-core contract. - `ol --json changelog -n abc` now emits `{"error":{"code":"INVALID_TYPE","message":"Count must be a positive integer"}}`. - `--json` / `--ndjson` now appear as global options in `ol --help` (existing per-subcommand `--json` flags still work the same). ## Test plan - [x] `npm run type-check` - [x] `npm run lint:check` + `npm run format:check` - [x] `npm test` (108 tests pass; changelog suite slimmed from 6 tests to 2 wrapper smoke tests covering path-passthrough and footer URL; output suite gains `BaseCliError`-instance + `formatErrorJson` cases) - [x] Smoke `ol changelog -n 1` — version block + footer link unchanged - [x] Smoke `ol changelog -n abc` — human red error, exit 1 - [x] Smoke `ol --json changelog -n abc` — JSON error envelope, exit 1 - [x] Smoke `ol doc list --json` — per-subcommand `--json` still routes to output formatter 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

scottlovegrove and others added 3 commits May 9, 2026 09:00

chore: bump @doist/cli-core to 0.6.0

192f1a5

Picks up the released ./markdown and ./commands subpaths consumed by src/lib/markdown.ts and src/commands/changelog.ts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

doistbot requested a review from rfgamaral May 9, 2026 08:25

doistbot reviewed May 9, 2026

View reviewed changes

Comment thread src/lib/markdown.ts Outdated

Comment thread src/index.ts Outdated

Comment thread src/commands/changelog.test.ts

Comment thread src/commands/changelog.ts

Comment thread src/lib/output.ts

Comment thread src/index.ts

Comment thread src/types/marked-terminal-renderer.d.ts

scottlovegrove self-assigned this May 9, 2026

scottlovegrove added the 👀 Show PR PR must be reviewed before or after merging label May 9, 2026

scottlovegrove merged commit 3d90382 into main May 9, 2026
4 checks passed

scottlovegrove deleted the scottl/core-updates-2 branch May 9, 2026 08:46

doist-release-bot Bot added the released label May 9, 2026

scottlovegrove mentioned this pull request May 9, 2026

refactor: delegate markdown + changelog to @doist/cli-core Doist/twist-cli#210

Merged

8 tasks

rfgamaral reviewed May 11, 2026

View reviewed changes

scottlovegrove mentioned this pull request May 11, 2026

refactor: delegate ol changelog to @doist/cli-core/commands Doist/outline-cli#69

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: integrate @doist/cli-core 0.6.0 (markdown + changelog)#319

refactor: integrate @doist/cli-core 0.6.0 (markdown + changelog)#319
scottlovegrove merged 4 commits into
mainfrom
scottl/core-updates-2

scottlovegrove commented May 9, 2026

Uh oh!

doistbot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doist-release-bot Bot commented May 9, 2026

Uh oh!

rfgamaral left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

scottlovegrove commented May 9, 2026

Summary

Test plan

Uh oh!

doistbot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doist-release-bot Bot commented May 9, 2026

Uh oh!

rfgamaral left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants