fix: add UTF-8 charset to OAuth callback HTML responses#8
Merged
scottlovegrove merged 1 commit intomainfrom Jan 22, 2026
Merged
fix: add UTF-8 charset to OAuth callback HTML responses#8scottlovegrove merged 1 commit intomainfrom
scottlovegrove merged 1 commit intomainfrom
Conversation
The checkmark (✅) and cross (❌) characters in the auth success/error pages displayed as mojibake in browsers due to missing charset declaration. Add charset=utf-8 to Content-Type headers and meta charset tags to HTML. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
You know, I just figured that was just some weird "we show foreign letters" thing 😄 |
scottlovegrove
approved these changes
Jan 22, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
# 1.0.0 (2026-01-22) ### Bug Fixes * add UTF-8 charset to OAuth callback HTML responses ([#8](#8)) ([fcb2d49](fcb2d49)) ### Features * Add Biome linting, upgrade to Node 20, and add CI workflows ([#3](#3)) ([57f802e](57f802e)) * add loading animations with global API proxy integration ([#7](#7)) ([bf53bfb](bf53bfb)) * Add OAuth authentication with dynamic client registration ([#6](#6)) ([2845ebd](2845ebd)), closes [#5](#5) * add semantic release automation for NPM publishing ([#10](#10)) ([c756324](c756324)) * Refactor login command to auth with status/logout subcommands ([#4](#4)) ([59e6493](59e6493))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed character encoding issue in OAuth callback pages where checkmark (✅) displayed as mojibake
Similar fix as Doist/todoist-cli#17
Test plan
tw auth login