Skip to content

fix: improve domains page UX and button placement consistency#1249

Merged
Siumauricio merged 2 commits intoDokploy:canaryfrom
ali-issa:fix/domains-page-ux-improvements
Feb 1, 2025
Merged

fix: improve domains page UX and button placement consistency#1249
Siumauricio merged 2 commits intoDokploy:canaryfrom
ali-issa:fix/domains-page-ux-improvements

Conversation

@ali-issa
Copy link
Contributor

Fixes #1248

Changes

  • Made domain text white to match other clickable elements
  • Enhanced text truncation and responsive layout
  • Replaced Button components with semantic elements for static information (ports/protocols)
  • Improved hover states for better interaction feedback

Before & After

before
after

Context

These changes address usability friction points observed with new users. The improvements align the domains page with common platform patterns and Dokploy's existing UI conventions.

Testing

  • Tested across different screen sizes
  • Verified text truncation with long domain names
  • Confirmed hover states and click interactions
  • Checked accessibility with semantic markup changes

Let me know if you'd like any adjustments!

@ali-issa ali-issa requested a review from Siumauricio as a code owner January 31, 2025 08:08
@MuhammadM1998
Copy link
Contributor

Is adding a fixed "Open" button beside the edit & delete button a good idea? This will save an additional click to the Deployments tab then clicking the link. Maybe make it use the first available domain by default

@ali-issa
Copy link
Contributor Author

ali-issa commented Jan 31, 2025

@MuhammadM1998 I think you meant the General tab instead of Deployments. I completely agree with you. It was going to be my next PR. I had the same idea you mentioned, but how would we define which link is the default link? Dokploy itself doesn't differentiate between containers, so it doesn't know which one should be default. Maybe we could add a default switch in the modal when creating a new domain? If there's only one domain, it would automatically become the default.

@MuhammadM1998
Copy link
Contributor

I meant to add it in the top section that's always visible whatever the opened tab is. See the screenshot It should be inside the red square beside the other buttons

Untitled

but how would we define which link is the default link? Dokploy itself doesn't differentiate between containers, so it doesn't know which one should be default. Maybe we could add a default switch in the modal when creating a new domain? If there's only one domain, it would automatically become the default.

You're right that's why I think it should open the first domain by default until "Default Domain" gets implemented then we can use that. I suggested using the first domain for now as it would be faster to merge this then we can implement Default Domain in another PR.

@ali-issa
Copy link
Contributor Author

But what would happen if a user deletes the default domain and adds a different one instead? There would be unintentional side effects. Plus there would be no way to choose which one is the default one. This is a common use case when users want to add custom domains for different purposes (like one for the app and another for pgadmin).

@MuhammadM1998
Copy link
Contributor

MuhammadM1998 commented Jan 31, 2025

But what would happen if a user deletes the default domain and adds a different one instead? There would be unintentional side effects.

As it opens the first domain, this would work without problems and the newly added domain would open.

Plus there would be no way to choose which one is the default one. This is a common use case when users want to add custom domains for different purposes (like one for the app and another for pgadmin).

I think you're right, maybe it should be implemented in another PR where we can allow the user to select a default domain, then show that default domain as the button target

@Siumauricio Siumauricio merged commit f14ed51 into Dokploy:canary Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Domain Page: Improve UX and fix inconsistent button placement

3 participants