Feat : Fix backup file naming for Windows 11 compatibility (#2955)#2956
Open
Harikrishnan1367709 wants to merge 2 commits intoDokploy:canaryfrom
Open
Feat : Fix backup file naming for Windows 11 compatibility (#2955)#2956Harikrishnan1367709 wants to merge 2 commits intoDokploy:canaryfrom
Harikrishnan1367709 wants to merge 2 commits intoDokploy:canaryfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Backup files with timestamps containing colons (
:) were being truncated/renamed when downloaded on Windows 11, making them unidentifiable.Solution
Updated backup file naming format from
YYYY-MM-DDTHH:MM:SS.SSSZtoYYYY-MM-DD_HH-MM-SS_SSSZby replacing:T→_(date/time separator):→-(time separators).→_(milliseconds separator)Example
Before:
2024-01-15T14:30:45.123Z.tarAfter:
2024-01-15_14-30-45_123Z.tar