3979 collapsed sidebar state has usability and visual issues#4012
Merged
Siumauricio merged 3 commits intocanaryfrom Mar 16, 2026
Merged
Conversation
- Replaced direct state checks with a derived variable `isCollapsed` for better readability and maintainability. - Updated class names and conditions in the SidebarLogo component to use the new `isCollapsed` variable. - Adjusted overflow behavior in Sidebar and SidebarContent components for improved layout management.
- Removed TimeBadge from the ShowProjects component and integrated it into the BreadcrumbSidebar. - Added a query to determine if the environment is cloud-based, allowing for conditional display of the TimeBadge. - Updated layout in BreadcrumbSidebar for improved spacing and organization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Please describe in a short paragraph what this PR is about.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #3979
Screenshots (if applicable)
Greptile Summary
This PR fixes collapsed sidebar usability and visual issues (#3979) through several focused changes:
isCollapsedvariable (state === "collapsed" && !isMobile) inSidebarLogoto prevent collapsed-state styles from applying on mobile, where the sidebar is a full-width sheet overlay rather than a narrow icon strip.TimeBadgefrom an absolute-positioned element in the Projects page into the sharedBreadcrumbSidebarcomponent, ensuring consistent placement across all project-related pages.SidebarContentfromoverflow-hiddentooverflow-y-autowhen collapsed, allowing users to scroll through sidebar items that exceed the available height.TimeBadgeimport andisCloudquery inshow.tsxare now unused and should be removed.Confidence Score: 4/5
apps/dokploy/components/dashboard/projects/show.tsxhas unusedTimeBadgeimport andisCloudquery that should be cleaned up.Comments Outside Diff (1)
apps/dokploy/components/dashboard/projects/show.tsx, line 52 (link)Unused import left behind after refactor
TimeBadgeis still imported here but is no longer used in this component — it was moved intoBreadcrumbSidebar. This will likely trigger a lint/build warning. Similarly, theisCloudquery on line 61 is now dead code since the only consumer was the removedTimeBadgeblock.Last reviewed commit: 4871520