feat: add view mounts, config, and terminal to container actions#4221
Merged
Siumauricio merged 1 commit intocanaryfrom Apr 14, 2026
Merged
feat: add view mounts, config, and terminal to container actions#4221Siumauricio merged 1 commit intocanaryfrom
Siumauricio merged 1 commit intocanaryfrom
Conversation
Add a new "View Mounts" action to the container dropdown that displays volume and bind mounts in a formatted table (type, source, destination, mode, read/write). Also add "View Config" and "Terminal" actions to the compose containers tab which previously only had logs and lifecycle actions.
This was referenced Apr 14, 2026
Comment on lines
+68
to
+70
| {mounts.length === 0 ? ( | ||
| <div className="text-center text-muted-foreground py-8"> | ||
| No mounts found for this container. |
Contributor
There was a problem hiding this comment.
Missing loading state conflates "no mounts" with "still fetching"
When the dialog is opened before the query resolves, mounts is [] (the ?? [] fallback) and the "No mounts found" empty-state message is displayed — indistinguishable from a container that genuinely has no mounts. Consider checking isPending to show a loading indicator.
Suggested change
| {mounts.length === 0 ? ( | |
| <div className="text-center text-muted-foreground py-8"> | |
| No mounts found for this container. | |
| {isPending ? ( | |
| <div className="text-center text-muted-foreground py-8"> | |
| Loading mounts… | |
| </div> | |
| ) : mounts.length === 0 ? ( | |
| <div className="text-center text-muted-foreground py-8"> | |
| No mounts found for this container. | |
| </div> |
You'll need to destructure isPending from the useQuery call:
const { data, isPending } = api.docker.getConfig.useQuery(…);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker inspectquery — no new API endpoints neededGreptile Summary
This PR adds View Mounts, View Config, and Terminal actions to the compose containers tab, and adds View Mounts to the standalone Docker containers table — all by reusing the existing
api.docker.getConfigquery with no new API endpoints. The implementation is consistent with the patterns already established byShowContainerConfigandDockerTerminalModal.Confidence Score: 5/5
ShowContainerMountscomponent correctly reuses the existinggetConfigquery (React Query deduplicates it withShowContainerConfig), nesting inside Radix dialogs is safe given the outer logs-dialog is always closed when the new modals are triggered, and the rest of the changes are straightforward drop-ins following established patterns.Reviews (1): Last reviewed commit: "feat: add view mounts, view config, and ..." | Re-trigger Greptile