fix(templates): add fetch timeout and handle network errors gracefully#4336
Merged
Siumauricio merged 1 commit intocanaryfrom May 1, 2026
Merged
Conversation
Add 10s AbortSignal timeout to all template fetch calls so they fail cleanly instead of hanging indefinitely when templates.dokploy.com is unreachable. Add try/catch to getTags endpoint which was missing error handling, causing a 500 instead of returning an empty list. Closes #4282
dosubot
Bot
added
the
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbortSignal.timeout(10000)to allfetch()calls infetchTemplatesListandfetchTemplateFilesso requests fail cleanly in 10s instead of hanging indefinitely whentemplates.dokploy.comis unreachablegetTagstRPC endpoint which was missing error handling, causing a-32603 INTERNAL_SERVER_ERRORinstead of returning an empty arraygithub.tsby removing redundant try/catch blocks that only re-threw errorsCloses #4282