Merged
Conversation
Contributor
|
How come you didnt just use nextjs native way of adding title/metadata tags? |
Contributor
Author
|
@mezotv As far as I am aware that only works for the app router. Dokploy uses the pages router. |
Contributor
Oh true my bad, they really need to move to the app directory. |
Contributor
Author
|
@Siumauricio do you have any plans on moving to the app router? |
Contributor
|
Nice detail! Well done! |
Contributor
|
Yes @DJKnaeckebrot, I have plans, I just haven't had time to do the migration, the last time I tried it was a little complicated because there was a dependency that was node-pty that had conflicts with app router at that time, but I think that now it's probably already solved that problem, I also wanted to upgrade node to version 20 |
Siumauricio
approved these changes
Dec 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Titles to the pages.
Format is:
{pageName} | Dokploy for main and settings pages
Project {projectName} | Dokploy for Projects
Project {projectName} | {appName} | Dokploy for services/applications
Feel free to comment if you agree with the naming "convention" or want sth else :)