Skip to content

feat: add page titles#868

Merged
Siumauricio merged 1 commit intoDokploy:canaryfrom
DJKnaeckebrot:feat/page-titles
Dec 14, 2024
Merged

feat: add page titles#868
Siumauricio merged 1 commit intoDokploy:canaryfrom
DJKnaeckebrot:feat/page-titles

Conversation

@DJKnaeckebrot
Copy link
Contributor

Adding Titles to the pages.

Format is:

{pageName} | Dokploy for main and settings pages

Project {projectName} | Dokploy for Projects

Project {projectName} | {appName} | Dokploy for services/applications

Feel free to comment if you agree with the naming "convention" or want sth else :)

@mezotv
Copy link
Contributor

mezotv commented Dec 12, 2024

How come you didnt just use nextjs native way of adding title/metadata tags?

@DJKnaeckebrot
Copy link
Contributor Author

@mezotv As far as I am aware that only works for the app router. Dokploy uses the pages router.

@mezotv
Copy link
Contributor

mezotv commented Dec 12, 2024

@mezotv As far as I am aware that only works for the app router. Dokploy uses the pages router.

Oh true my bad, they really need to move to the app directory.

@DJKnaeckebrot
Copy link
Contributor Author

@Siumauricio do you have any plans on moving to the app router?

@enemyrr
Copy link
Contributor

enemyrr commented Dec 12, 2024

Nice detail! Well done!

@Siumauricio
Copy link
Contributor

Siumauricio commented Dec 13, 2024

Yes @DJKnaeckebrot, I have plans, I just haven't had time to do the migration, the last time I tried it was a little complicated because there was a dependency that was node-pty that had conflicts with app router at that time, but I think that now it's probably already solved that problem, I also wanted to upgrade node to version 20

@Siumauricio Siumauricio merged commit 0a3ab7c into Dokploy:canary Dec 14, 2024
@Siumauricio Siumauricio mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants