feat: display local IP alongside public IP in install success message#166
Merged
Conversation
Home servers and local VMs are often not reachable on their public IP because no port forwarding is configured, so the final install message now also prints the private (RFC1918) IP when one is detected and it differs from the address already shown. Closes #152 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The install script's final message only printed the public IP URL. Users installing Dokploy on local VMs or home hardware often can't reach that address because no port forwarding is configured, so a successful install looks broken.
This reuses the existing
get_private_ip()helper (already used for the swarm advertise address) to also print the local URL:The extra line is only shown when a private (RFC1918) IP is detected and it differs from the address already displayed — so VPS-only servers and users who passed
ADVERTISE_ADDRwith their local IP see no duplicate line.Testing
Verified inside an Alpine container (busybox
ash) by executing the exact functions and final-message block extracted from the script:172.17.0.2) ✅ADVERTISE_ADDRset to the private IP → single line, no duplicate ✅ADVERTISE_ADDRset to a distinct address → both lines ✅sh -nsyntax check passes ✅Closes #152
🤖 Generated with Claude Code