Add missing hook to print common object lines#33302
Closed
atm-etienne wants to merge 2 commits intoDolibarr:17.0from
Closed
Add missing hook to print common object lines#33302atm-etienne wants to merge 2 commits intoDolibarr:17.0from
atm-etienne wants to merge 2 commits intoDolibarr:17.0from
Conversation
Member
|
Such hook "printObjectLinesList" was never introduced in v17 (can't find in v21 either) |
eldy
added
Discussion
Contributor
Author
|
@eldy I see you changed the base branche from 17.0 to develop, then you revert it. |
Member
Repush in develop if not already present (changing myself generates too conflict). |
|
|
||
| $parameters = array('num'=>$num, 'dateSelector'=>$dateSelector, 'seller'=>$seller, 'buyer'=>$buyer, 'selected'=>$selected, 'table_element_line'=>$this->table_element_line); | ||
| $reshook = $hookmanager->executeHooks('printObjectLineTitle', $parameters, $this, $action); // Note that $action and $object may have been modified by some hooks | ||
| $parameters = array(); |
Contributor
There was a problem hiding this comment.
hello, maybe you can pass some parameters to the hook (seller, buyer...) ?
Contributor
|
PR pulled anew in #33641 ? |
Member
|
Yes, replaced by the new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX - Add missing hook to replace default lines list on Common Object card
On common object cards, there is a list of object lines (invoice lines, for example), which can be modified with a hook for the title line of the list, or a hook executed on each line.
However, there is no hook to completely replace this list.
Some objects have several hundred or even thousands of lines, which prevents the object's card from loading. We therefore need to be able to replace this list to enable the card to be displayed, and custom the list.