GIFF-Accountancy-2025 - Automatic numbering of accounting entries#33551
Merged
eldy merged 19 commits intoDolibarr:developfrom Mar 31, 2025
Merged
GIFF-Accountancy-2025 - Automatic numbering of accounting entries#33551eldy merged 19 commits intoDolibarr:developfrom
eldy merged 19 commits intoDolibarr:developfrom
Conversation
eldy
reviewed
Mar 20, 2025
| $fiscalStartMonth = getDolGlobalInt('SOCIETE_FISCAL_MONTH_START') ?: 1; | ||
| $docYear = dol_print_date($object->doc_date, '%Y'); | ||
| $docMonth = dol_print_date($object->doc_date, '%m'); | ||
| $docFiscalYear = $docMonth < $fiscalStartMonth ? $docYear - 1 : $docYear; |
Member
There was a problem hiding this comment.
Use parenthesis here. Result is suspicious without.
Member
There was a problem hiding this comment.
On line 153, it's better with : $fiscalStartMonth = getDolGlobalInt('SOCIETE_FISCAL_MONTH_START', 1);
eldy
added
the
PR to fix - Conflict or CI error to solve
jyhere
removed
the
PR to fix - Conflict or CI error to solve
aspangaro
reviewed
Mar 22, 2025
Member
aspangaro
left a comment
aspangaro
left a comment
There was a problem hiding this comment.
Seems ok. Some tests will be realized when this PR will be integrated
() param instead of ternary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More informations at :
#32703
(see comments for details)