fix(mail): lot of 0 after amount of total_ht and total_ttc #33763
Conversation
|
|
||
| // For backward compatibility | ||
| if ($onlykey != 2) { | ||
| if (is_object($object)) $object->update_price(); |
There was a problem hiding this comment.
We should not have any SQL action inside the getCommonSubstitutionArray that should remain a memory only function.
Can you describe how to reproduce the problem ?
There was a problem hiding this comment.
@eldy A customer reported an issue with the TOTAL_TTC variable. It displays too many zeros at the end, even though the configuration limits it to two decimal places. I don't understand why.
There was a problem hiding this comment.
First thing to do is to look into database. If data was inserted directly in database or with old version the value may have not be rounded by the rounding limit.
Note: We round during the insert, never when showing on screen. Data must have correct rounding in database. if not, database is corrupted.
if yes, rounding on screen is useless.
There was a problem hiding this comment.
Ok, I see your point. I'm going to check this right now, thanks.
eldy
added
the
PR not qualified
2 participants
FIX|Fix lot of 0 after amount of total_ht and total_ttc
I've added update_price before substitution because there was a lot of 0 after the price in the email.