Conversation
Replaces obsolete CellValue with CadValue in table entities, cell content, and custom data entries. Updates all DWG/DXF reading logic to use CadValue and related types (CadValueType, CadValueUnitType). Enforces CellValue deprecation with Obsolete(error: true). Adds CadValueTemplate to CadTableCellContentTemplate for improved value management and parsing consistency.
Refactored TableEntity and related classes to use a new CadValue property (with private setter and SetValue method) for cell content, replacing the old Value and Text properties. Updated all DWG/DXF readers and templates to use the new approach, ensuring type safety and consistency. Improved encapsulation and parsing logic for table cell values. Updated tests and refactored template classes for clarity.
Closed
Refactored and reorganized enums related to TableEntity.Cell by moving OverrideFlags and CellAlignmentType to separate files and making CellAlignmentType a direct member of TableEntity. Declared TableEntity.Cell as partial and removed nested enums. Added new properties to Cell for content management, custom data, geometry, and linked data support. Updated all usages of the affected enums in IO and reader classes. This improves code maintainability and clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the obsolete class
CellValue.