fix: Handling bit promotision that c/c++ might do with sign extension#1010
Merged
DomCR merged 1 commit intoDomCR:masterfrom Mar 24, 2026
Merged
Conversation
DomCR
approved these changes
Mar 24, 2026
Owner
|
Looks good! Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a one file where:
EXAC_ESW
90
-64511
That value was throwing exception in DxfReader.
However, after closely analyzing it:
-64511 (signed 16-bit) == 1025 (unsigned)
The intention for ProxyFlag was cleary like so, it seems it's about bit operations that apparently some .cad editors might so on this value.
This fix helps for this case and analogous, doesn't break things.