refactor: use System.Convert where applicable in group code value conversion#1043
Merged
DomCR merged 1 commit intoDomCR:masterfrom Apr 27, 2026
Merged
Conversation
…version This PR normalizes value conversion by using `System.Convert` where applicable, while preserving the original switch order and formatting.
DomCR
added
code refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR normalizes value conversion by using
System.Convertwhere applicable, while preserving the original switch order and formatting.When calling
SetDimensionOverride(), some override style values caused issues because explicit casts were not always valid.For example,
ArrowHead.SeparateBlocksraised an error because anInt16was expected, while the provided value was correctly abool.I tested these changes with my use cases, and everything worked as expected.
Tasks done in this PR