Hatch explode#1105
Open
DomCR wants to merge 5 commits into
Open
Conversation
Updated namespaces for consistency and organization. Refactored `HatchTests.cs` to improve readability and added new test cases for `Hatch` functionality. Enhanced `Hatch.cs` with new properties and methods, including `Explode`, `ApplyTransform`, and `GetBoundingBox`. Simplified `HatchStyleType` enum and added logic in `LocalSampleTests.cs` to handle `Hatch` pattern explosion. Removed redundant code and improved maintainability.
Refactor BoundaryPath and edge classes to support intersection detection with Line2D, bounding box calculations, and entity conversion. Improve HatchPattern line geometry, pattern file I/O, and transformation logic. Update Hatch.ExplodePattern to use new intersection logic. Modernize code and update CSMath submodule for geometric operations.
Refactored the ExplodePattern method in the Hatch class to generate line entities between intersection pairs of pattern lines and boundaries, replacing the previous approach of adding circles at intersections. Utilized modern C# syntax and improved intersection handling. In LocalSampleTests, set all exploded entities' color to red before adding to the document. Added necessary using directives for geometry and LINQ support.
Improved XML docs for Explode methods, refactored emitDashedSegment to use Line2D, removed unused helpers, and clarified dash pattern logic. Moved GetBoundingBox to a public override. Updated CSUtilities submodule reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Short description about this PR
Tasks done in this PR
Related Issues / Pull Requests
Notes for reviewer