Skip to content

Issue 879 #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DomCR merged 4 commits into from
Nov 20, 2025
Merged

Issue 879 #885

DomCR merged 4 commits into from
Nov 20, 2025

Conversation

@DomCR
Copy link
Owner

@DomCR DomCR commented Nov 20, 2025

Description

Fix the owner for SortenEntitiesTable when cloning the block record.

@DomCR DomCR linked an issue Nov 20, 2025 that may be closed by this pull request
SortEntitiesTable ignored in cloned BlockRecord #879
Closed
@DomCR DomCR added bug Something isn't working minor Updates the minor version on merge. labels Nov 20, 2025
@DomCR DomCR merged commit 0c8d311 into master Nov 20, 2025
@DomCR DomCR deleted the issue-879_sortentitiestable-ignored-in-cloned-blockrecord branch November 20, 2025 10:01
@mme1950
Copy link
Contributor

mme1950 commented Nov 20, 2025

Hi @DomCR,
this will work.
However, after base.Clone() the XDictionary and the SortEntitiesTable is already cloned, except that the BlockOwner property is not handled.
I think it would be sufficient to set the BlockOwner property of the SortEntitiesTable rather to build a new table?

@DomCR
Copy link
Owner Author

DomCR commented Nov 20, 2025

Let me test this in this other PR and I'll merge this change, thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working minor Updates the minor version on merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SortEntitiesTable ignored in cloned BlockRecord

3 participants

@DomCR @mme1950