Skip to content

Update syncPubKeyDomain to achene.app#1124

Merged
pawel-kow merged 3 commits into
Domain-Connect:masterfrom
PeteJStewart:patch-1
May 21, 2026
Merged

Update syncPubKeyDomain to achene.app#1124
pawel-kow merged 3 commits into
Domain-Connect:masterfrom
PeteJStewart:patch-1

Conversation

@PeteJStewart
Copy link
Copy Markdown
Contributor

@PeteJStewart PeteJStewart commented May 20, 2026

Description

Corrects syncPubKeyDomain from domainconnect.achene.app to achene.app.
Update logo URL.

Background: Cloudflare builds the public-key TXT lookup as {key}.{syncPubKeyDomain}. The key URL parameter carries the sub-label prefix (domainconnect), so the full lookup domain must be domainconnect.achene.app. The previous value (domainconnect.achene.app) caused Cloudflare to query domainconnect.achene.app.domainconnect.achene.app, which does not exist. The JWT returned had perms: [] and the flow failed silently.

No DNS records were changed — only the syncPubKeyDomain metadata field and the logo URL.

Type of change

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.jsonachene.app.customdomain.json
  • resource URL provided with logoUrl is actually served by a webserver — https://achene.app/favicon-light.svg

Checklist of common problems

  • syncPubKeyDomain is set — achene.app
  • warnPhishing is not set alongside syncPubKeyDomain
  • syncRedirectDomain is set — achene.app (used in the synchronous redirect flow)
  • no TXT record contains SPF content — no TXT records in this template
  • txtConflictMatchingMode — not applicable, no TXT records
  • no variable is used as a bare full record value — no variables used in this template
  • no bare variable is used as the full host label — no variables used
  • no variable is used in the host field to create a subdomain — host parameter is used via hostRequired: true
  • %host% does not appear explicitly in any host attribute — host is "@" (expands to the provided host parameter)
  • essential — not applicable, no records the end user would need to modify independently

Online Editor test results

hostRequired: true so apex test is not required — only subdomain test needed.

Editor test link(s):

Test achene.app/customdomain tinkr.co.uk/learn

The syncPubKeyDomain contained the key
@github-actions github-actions Bot added hostRequired hostRequired is set Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. labels May 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

JSON Filename Check Passed

@github-actions github-actions Bot added the Test links missing No test links from Online Editor provided label May 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

JSON Schema Validation Passed

@github-actions github-actions Bot added the automerge-possible Label indicating, that restrictive linter checks all pass. For now it's PoC. label May 20, 2026
@github-actions
Copy link
Copy Markdown

Linter OK

achene.app.customdomain.json

Level Code Note

@github-actions github-actions Bot removed Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels May 20, 2026
@github-actions github-actions Bot added Test links missing No test links from Online Editor provided and removed Test links missing No test links from Online Editor provided labels May 20, 2026
@github-actions github-actions Bot added Test links missing No test links from Online Editor provided and removed Test links missing No test links from Online Editor provided labels May 20, 2026
@github-actions
Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked
  OK  Online Editor test results: 1 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

@pawel-kow pawel-kow added this pull request to the merge queue May 21, 2026
Merged via the queue into Domain-Connect:master with commit 53c0c04 May 21, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-possible Label indicating, that restrictive linter checks all pass. For now it's PoC. hostRequired hostRequired is set

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants