feat: Modernize ryuu-proxy to v5.0.0 - Fix axios compatibility with modern tooling#63
Merged
jontiritilli merged 4 commits intomasterfrom Oct 28, 2025
Merged
feat: Modernize ryuu-proxy to v5.0.0 - Fix axios compatibility with modern tooling#63jontiritilli merged 4 commits intomasterfrom
jontiritilli merged 4 commits intomasterfrom
Conversation
added 4 commits
October 27, 2025 09:39
docs: add CLAUDE.md for guidance on using Claude Code with the project build: update package version to 4.5.0-beta.0 and ryuu-client dependency test: update tests to use require for ryuu-client and adjust stubs refactor: replace getDomoDomain with getDomainPromise in Transport tests style: fix typos and improve consistency in test descriptions and assertions refactor: re-export Manifest type from ryuu-client in models.ts
…nting build: switch package manager to pnpm for improved dependency management chore: update CHANGELOG.md with detailed release notes for version 5.0.0 chore: update package.json scripts and dependencies for modern tooling refactor: improve type safety and modernize codebase with TypeScript strict mode refactor: update import statements to use ES6 module syntax refactor: enhance error handling and code readability throughout the codebase refactor: update axios and related dependencies for compatibility with modern Node.js refactor: improve cookie handling and proxy agent initialization logic refactor: update tsconfig.json to target ES2020 and enable strict mode test: add type annotations to test files for better type safety test: create tsconfig.test.json for test-specific TypeScript configuration
plumppig
approved these changes
Oct 28, 2025
mbrnak
reviewed
Oct 28, 2025
mbrnak
left a comment
mbrnak
left a comment
There was a problem hiding this comment.
Fine by me. Feel free to ignore my comments if you feel like it.
| port: proxyPort, | ||
| }, | ||
| recentLogin.devToken, | ||
| ) as any; |
There was a problem hiding this comment.
This feels like something we should fix instead of casting it to any?
Comment on lines
+3
to
8
|
|
||
| url: string; | ||
|
|
||
| error: string; | ||
|
|
||
| proxy: string; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete modernization of
@domoinc/ryuu-proxyto v5.0.0, fixing critical compatibility issues with modern Node.js build tools and updating all dependencies to current versions.Primary Issue Fixed
Resolves the
Package subpath './lib/defaults' is not defined by "exports"error that prevented the package from working with modern bundlers and Node.js versions. This was caused by using an outdated version of axios (0.27.2) that wasn't compatible with Node.js module resolution.Major Changes
Breaking Changes
Infrastructure Improvements
@ts-ignorecomments with proper typingtsconfig.test.jsonfor test filesCode Quality
anytypes at library boundaries)Build & Release
prepublishOnlyhook for safety (runs lint, test, build).npmrcfor pnpm configurationAPI Compatibility
✅ No breaking changes to the public API - existing code using this package should continue to work without modifications.
The only requirements for consumers:
Files Changed
src/with modern TypeScript patternsTesting
Migration Notes
Consuming applications should: