fix: Over-sharpened images from filter quality#208
Merged
PartyDonut merged 1 commit intodevelopfrom Jan 31, 2025
Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request addresses over-sharpened images by removing the explicit setting of Class diagram showing image rendering components affected by filter quality changesclassDiagram
class FladderImage {
<<ConsumerWidget>>
-filterQuality: removed
-placeholderFilterQuality: removed
}
class TrickPlayPainter {
<<CustomPainter>>
-filterQuality: removed
+paint()
}
class PhotoViewerScreen {
<<ConsumerStatefulWidget>>
-filterQuality: removed
}
class DetailScaffold {
<<ConsumerStatefulWidget>>
-filterQuality: removed
}
note for FladderImage "Removed explicit high filter quality settings"
note for TrickPlayPainter "Removed high filter quality from paint object"
Flow diagram of image rendering quality changesflowchart TD
A[Image Source] --> B{Image Rendering}
B -->|Before| C[High Filter Quality]
B -->|After| D[Default Framework Quality]
C --> E[Over-sharpened Result]
D --> F[Natural Result]
style E fill:#ffcccc
style F fill:#ccffcc
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @PartyDonut - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix over-sharpening of images throughout the app
Issue Being Fixed
Resolves #203