Skip to content

fix: Over-sharpened images from filter quality#208

Merged
PartyDonut merged 1 commit intodevelopfrom
feature/Improve-posters-rendering
Jan 31, 2025
Merged

fix: Over-sharpened images from filter quality#208
PartyDonut merged 1 commit intodevelopfrom
feature/Improve-posters-rendering

Conversation

@PartyDonut
Copy link
Copy Markdown
Collaborator

Pull Request Description

Fix over-sharpening of images throughout the app

Issue Being Fixed

Resolves #203

@PartyDonut PartyDonut added the bug Something isn't working label Jan 31, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Jan 31, 2025

Reviewer's Guide by Sourcery

This pull request addresses over-sharpened images by removing the explicit setting of filterQuality: FilterQuality.high in multiple image widgets and a custom painter. This change allows the framework to use its default filter quality, which is generally more appropriate and avoids the over-sharpening effect.

Class diagram showing image rendering components affected by filter quality changes

classDiagram
    class FladderImage {
        <<ConsumerWidget>>
        -filterQuality: removed
        -placeholderFilterQuality: removed
    }
    class TrickPlayPainter {
        <<CustomPainter>>
        -filterQuality: removed
        +paint()
    }
    class PhotoViewerScreen {
        <<ConsumerStatefulWidget>>
        -filterQuality: removed
    }
    class DetailScaffold {
        <<ConsumerStatefulWidget>>
        -filterQuality: removed
    }
    note for FladderImage "Removed explicit high filter quality settings"
    note for TrickPlayPainter "Removed high filter quality from paint object"
Loading

Flow diagram of image rendering quality changes

flowchart TD
    A[Image Source] --> B{Image Rendering}
    B -->|Before| C[High Filter Quality]
    B -->|After| D[Default Framework Quality]
    C --> E[Over-sharpened Result]
    D --> F[Natural Result]
    style E fill:#ffcccc
    style F fill:#ccffcc
Loading

File-Level Changes

Change Details Files
Removed explicit filterQuality: FilterQuality.high from FladderImage widget.
  • Removed filterQuality: FilterQuality.high.
  • Removed placeholderFilterQuality: FilterQuality.low.
lib/util/fladder_image.dart
Removed explicit filterQuality: FilterQuality.high from _TrickPlayPainter.
  • Removed paint.filterQuality = FilterQuality.high.
lib/widgets/shared/trick_play_image.dart
Removed explicit filterQuality: FilterQuality.high from Image widget in PhotoViewerScreen.
  • Removed filterQuality: FilterQuality.high.
lib/screens/photo_viewer/photo_viewer_screen.dart
Removed explicit filterQuality: FilterQuality.high from DetailScaffold widget.
  • Removed filterQuality: FilterQuality.high.
lib/screens/shared/detail_scaffold.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PartyDonut - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@PartyDonut PartyDonut merged commit b470c26 into develop Jan 31, 2025
1 check passed
@PartyDonut PartyDonut deleted the feature/Improve-posters-rendering branch January 31, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant