chore: Move to different iconsax library#301
Merged
PartyDonut merged 1 commit intodevelopfrom Apr 5, 2025
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 51 out of 71 changed files in this pull request and generated no comments.
Files not reviewed (20)
- lib/models/account_model.dart: Language not supported
- lib/models/collection_types.dart: Language not supported
- lib/models/item_base_model.dart: Language not supported
- lib/models/syncing/sync_item.dart: Language not supported
- lib/models/video_stream_model.dart: Language not supported
- lib/screens/book_viewer/book_viewer_controls.dart: Language not supported
- lib/screens/collections/add_to_collection.dart: Language not supported
- lib/screens/details_screens/book_detail_screen.dart: Language not supported
- lib/screens/details_screens/episode_detail_screen.dart: Language not supported
- lib/screens/details_screens/movie_detail_screen.dart: Language not supported
- lib/screens/details_screens/season_detail_screen.dart: Language not supported
- lib/screens/details_screens/series_detail_screen.dart: Language not supported
- lib/screens/home_screen.dart: Language not supported
- lib/screens/library_search/library_search_screen.dart: Language not supported
- lib/screens/library_search/widgets/library_filter_chips.dart: Language not supported
- lib/screens/library_search/widgets/library_saved_filters.dart: Language not supported
- lib/screens/library_search/widgets/library_views.dart: Language not supported
- lib/screens/library_search/widgets/suggestion_search_bar.dart: Language not supported
- lib/screens/login/lock_screen.dart: Language not supported
- lib/screens/login/login_edit_user.dart: Language not supported
Contributor
Reviewer's Guide by SourceryThis pull request migrates the project from the Updated class diagram for ItemBaseModelclassDiagram
class ItemBaseModel {
-IconData icon
-IconData selectedicon
}
note for ItemBaseModel "ItemBaseModel now uses IconsaxPlusLinear and IconsaxPlusBold for icons."
ItemBaseModel : -IconsaxOutline.folder_2 -> -IconsaxPlusLinear.folder_2
ItemBaseModel : -IconsaxBold.folder_2 -> -IconsaxPlusBold.folder_2
ItemBaseModel : -IconsaxOutline.music -> -IconsaxPlusLinear.music
ItemBaseModel : -IconsaxBold.music -> -IconsaxPlusBold.music
ItemBaseModel : -IconsaxOutline.video -> -IconsaxPlusLinear.video
ItemBaseModel : -IconsaxBold.video -> -IconsaxPlusBold.video
ItemBaseModel : -IconsaxOutline.video_horizontal -> -IconsaxPlusLinear.video_horizontal
ItemBaseModel : -IconsaxBold.video_horizontal -> -IconsaxPlusBold.video_horizontal
ItemBaseModel : -IconsaxOutline.video_vertical -> -IconsaxPlusLinear.video_vertical
ItemBaseModel : -IconsaxBold.video_vertical -> -IconsaxPlusBold.video_vertical
ItemBaseModel : -IconsaxOutline.picture_frame -> -IconsaxPlusLinear.picture_frame
ItemBaseModel : -IconsaxBold.picture_frame -> -IconsaxPlusBold.picture_frame
ItemBaseModel : -IconsaxOutline.user -> -IconsaxPlusLinear.user
ItemBaseModel : -IconsaxBold.user -> -IconsaxPlusBold.user
ItemBaseModel : -IconsaxOutline.gallery -> -IconsaxPlusLinear.gallery
ItemBaseModel : -IconsaxBold.gallery -> -IconsaxPlusBold.gallery
ItemBaseModel : -IconsaxOutline.folder -> -IconsaxPlusLinear.folder
ItemBaseModel : -IconsaxBold.folder -> -IconsaxPlusBold.folder
ItemBaseModel : -IconsaxOutline.bookmark -> -IconsaxPlusLinear.bookmark
ItemBaseModel : -IconsaxBold.bookmark -> -IconsaxPlusBold.bookmark
ItemBaseModel : -IconsaxOutline.archive_book -> -IconsaxPlusLinear.archive_book
ItemBaseModel : -IconsaxBold.archive_book -> -IconsaxPlusBold.archive_book
ItemBaseModel : -IconsaxOutline.book -> -IconsaxPlusLinear.book
ItemBaseModel : -IconsaxBold.book -> -IconsaxPlusBold.book
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @PartyDonut - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a consistent naming convention for the icon libraries (e.g., always use
IconsaxPlusBoldinstead of mixingIconsaxBoldandIconsaxPlusBold).
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Move to different iconsax library, change some collection icons